Open
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
force-pushed
the
04-23-fix_v2_subgraph_and_multiselection_fixes
branch
from
e088557 to
dffe0b0
Compare
camielvs
commented
Apr 23, 2026
| return { onSelectionChange }; | ||
| return { | ||
| onSelectionChange, | ||
| selectionMode: metaKeyPressed ? SelectionMode.Partial : SelectionMode.Full, |
Collaborator
Author
There was a problem hiding this comment.
we can inverse this if we prefer partial selection mode to be the default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v2 editor fixes related to multiselect & subgraphs.
Fixes inconsistent messaging and iconography for subgraph creation: "Create Subgraph" now always uses that text + Layers icon. Both subgraph creation flows have been consolidated into one
CreateSubgraphFormcomponent.Adds v1 editor multiselection modes to v2 editor (SHIFT + DRAG to full select & SHIFT + CMD + DRAG to partial select). We can reverse the modes->key shortcuts if we prefer.
Fixes an issue where created subgraphs would appear at arbitrary coordinates rather than in the same location of where the nodes were.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
subgraph creation input
subgraph creation position BEFORE
subgraph creation position AFTER
Test Instructions
Additional Comments