feat: v2: Migrate Collapsible Nodes to v2 Editor#2177
Open
camielvs wants to merge 1 commit into04-28-chore_v2_hide_empty_config_sectionfrom
Open
feat: v2: Migrate Collapsible Nodes to v2 Editor#2177camielvs wants to merge 1 commit into04-28-chore_v2_hide_empty_config_sectionfrom
camielvs wants to merge 1 commit into04-28-chore_v2_hide_empty_config_sectionfrom
Conversation
3 tasks
🎩 PreviewA preview build has been created at: |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camielvs
force-pushed
the
04-28-feat_v2_migrate_collapsible_nodes_to_v2_editor
branch
from
b9ceeb6 to
c65a422
Compare
3 tasks
camielvs
force-pushed
the
04-28-chore_v2_hide_empty_config_section
branch
from
0da5f93 to
365985e
Compare
camielvs
force-pushed
the
04-28-feat_v2_migrate_collapsible_nodes_to_v2_editor
branch
from
c65a422 to
dd0c59c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the v1 "Collapsible Nodes" functionality in the v2 editor. Feature parity should be identical. Collapsed state is toggleable via Task Configuration and should be visually the same and functionally the same as v1.
To facilitate this I have renamed the existing v2 "collapsed" nodes (which are the nodes rendered when greatly zxoomed out) to "simplified" nodes. I have done this to reduce in-code confusion about which feature is which (and thus leading to erroneous AI programming).
This PR also fixes an issue where annotations were not carried over when duplicating/copy-pasting a node.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/596
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Select a task in v2 editor. Go to configuration section and toggle "Collapse Node" on. Confirm that collapsed Node behaviour is identical to v1 editor. (unused inputs & outputs are hidden & collapsed state can be expanded by clicking the row).
Additionally, confirm that the existing v2 "collapse" functionality (now renamed to "simplified") also continues to work as expected - i.e. when zooming out the simplified node style will be rendered.
Additional Comments