fix: v2: New Windows fit to content#2190
Closed
camielvs wants to merge 1 commit into05-01-chore_v2_windows_are_resizeable_in_any_directionfrom
Closed
fix: v2: New Windows fit to content#2190camielvs wants to merge 1 commit into05-01-chore_v2_windows_are_resizeable_in_any_directionfrom
camielvs wants to merge 1 commit into05-01-chore_v2_windows_are_resizeable_in_any_directionfrom
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🎩 PreviewA preview build has been created at: |
3 tasks
Collaborator
Author
|
Actually it turns out this is essentially a non-issue. The original problem must have been fixed elsewhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small improvement to floating windows so that they fit size (within reason) to their content when first created. This is to avoid giant empty windows being created over the top of the canvas, as well as ludicrously small windows that are not helpful.
Additionally, this PR moves the resizable and content fitting logic into separate hooks for better readability and future reuse.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/611
Type of Change
Checklist
Screenshots (if applicable)
before
after
Test Instructions
Create some new floating windows and confirm they are reasonably sized.
Additional Comments