Skip to content

feat: v2 - change window height for docked windows#2200

Draft
maxy-shpfy wants to merge 1 commit into05-03-feat_v2_-_runs_and_submissions_-_add_latest_runfrom
05-03-feat_v2_-_change_window_height_for_docked_windows
Draft

feat: v2 - change window height for docked windows#2200
maxy-shpfy wants to merge 1 commit into05-03-feat_v2_-_runs_and_submissions_-_add_latest_runfrom
05-03-feat_v2_-_change_window_height_for_docked_windows

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 4, 2026

Description

Fixes layout and sizing behavior for docked windows. The content container now uses flexbox with overflow-hidden to properly constrain its children, and the inner content div uses flex-1 min-h-0 overflow-auto to allow scrolling within the available space rather than overflowing the container. The window height is now explicitly controlled via model.effectiveDockedHeight, ensuring the docked window respects its resized height. Additionally, the minimum docked window height has been reduced from 100px to 50px to allow more compact docking.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • Improvement
  • New feature
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Open a docked window and resize it by dragging the resize handle.
  2. Verify the window respects the resized height and content scrolls within the window rather than overflowing.
  3. Verify the window can be resized down to 50px minimum height.

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

🎩 Preview

A preview build has been created at: 05-03-feat_v2_-_change_window_height_for_docked_windows/8356dca

Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 4, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_change_window_height_for_docked_windows branch from 4172264 to 476bd9c Compare May 4, 2026 05:36
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_runs_and_submissions_-_add_latest_run branch 2 times, most recently from 43e295f to effa810 Compare May 4, 2026 05:42
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_change_window_height_for_docked_windows branch from 476bd9c to 0ab3122 Compare May 4, 2026 05:42
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_change_window_height_for_docked_windows branch from 0ab3122 to 8356dca Compare May 4, 2026 20:10
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_runs_and_submissions_-_add_latest_run branch from effa810 to 490871b Compare May 4, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant