Skip to content

feat: v2 - minicontent for history window#2269

Open
maxy-shpfy wants to merge 1 commit into
05-01-feat_v2_-_mini_content_for_collapsed_docked_windowsfrom
05-13-feat_v2_-_minicontent_for_history_window
Open

feat: v2 - minicontent for history window#2269
maxy-shpfy wants to merge 1 commit into
05-01-feat_v2_-_mini_content_for_collapsed_docked_windowsfrom
05-13-feat_v2_-_minicontent_for_history_window

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 14, 2026

Description

Adds a mini content component for the History window that displays compact undo/redo buttons. The HistoryWindowMiniContent component renders two icon-only buttons (Undo and Redo) that are enabled or disabled based on the current undo/redo state. This mini content is registered with the History window so it can be displayed in a collapsed/mini view of the panel.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Screen Recording 2026-05-13 at 5.22.20 PM.mov (uploaded via Graphite)

Test Instructions

  1. Open the pipeline editor.
  2. Make a change to trigger an undoable action.
  3. Collapse or minimize the History window panel.
  4. Verify that the undo and redo buttons appear in the mini view.
  5. Confirm that the undo button is enabled after making a change and that clicking it correctly undoes the action.
  6. Confirm that the redo button becomes enabled after undoing and correctly redoes the action.

Additional Comments

Pointer events on the buttons are stopped from propagating to prevent unintended interactions with the surrounding window drag/resize handlers.

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

🎩 Preview

A preview build has been created at: 05-13-feat_v2_-_minicontent_for_history_window/93c83fd

@maxy-shpfy maxy-shpfy marked this pull request as ready for review May 14, 2026 00:22
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner May 14, 2026 00:23
@maxy-shpfy maxy-shpfy force-pushed the 05-13-feat_v2_-_minicontent_for_history_window branch from 56ec36a to 522f084 Compare May 14, 2026 04:24
@maxy-shpfy maxy-shpfy force-pushed the 05-01-feat_v2_-_mini_content_for_collapsed_docked_windows branch from 15d654a to 2e116a0 Compare May 14, 2026 04:24
return (
<InlineStack gap="1">
<Button
type="button"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type="button"

type="button"
variant="outline"
size="icon"
className="size-8 shrink-0 rounded-md"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="size-8 shrink-0 rounded-md"

<Icon name="Undo2" size="sm" />
</Button>
<Button
type="button"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type="button"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we really need to get the primitive updated if this is going to continue to be an issue

type="button"
variant="outline"
size="icon"
className="size-8 shrink-0 rounded-md"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="size-8 shrink-0 rounded-md"

@maxy-shpfy maxy-shpfy force-pushed the 05-01-feat_v2_-_mini_content_for_collapsed_docked_windows branch from 2e116a0 to b2a54a9 Compare May 14, 2026 21:56
@maxy-shpfy maxy-shpfy force-pushed the 05-13-feat_v2_-_minicontent_for_history_window branch from 522f084 to 93c83fd Compare May 14, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants