fix context panel on node dragging #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
maxy-shpfy
commented
Aug 16, 2025
| children: ReactNode; | ||
| }) => { | ||
| const { setNodes } = useReactFlow(); | ||
| const defaultContentRef = useRef<ReactNode>(defaultContent); |
Collaborator
Author
There was a problem hiding this comment.
This ref is needed to make "clearContent" stable. Another approach to try - is to extract the piece of JSX in PipelineEditor and other places, where we using <ContextPanelProvider>.
const pipelineDetails = useMemo(() => <PipelineDetails />, []);
...
<ContextPanelProvider defaultContent={pipelineDetails}>
maxy-shpfy
force-pushed
the
08-16-fix_context_panel_on_node_dragging
branch
3 times, most recently
from
a23bf03 to
39e01e3
Compare
maxy-shpfy
commented
Dec 4, 2025
| setArguments, | ||
| setAnnotations, | ||
| setCacheStaleness, | ||
| } = data.callbacks ?? DEFAULT_TASK_NODE_CALLBACKS; |
Collaborator
Author
There was a problem hiding this comment.
We need stable references
camielvs
reviewed
Dec 5, 2025
| type, | ||
| }); | ||
| }; | ||
| const notify = useCallback( |
Collaborator
There was a problem hiding this comment.
iirc we're running the latest React and we should no longer need to explicitly call useCallback?
Collaborator
Author
There was a problem hiding this comment.
In case if we use Compiler. But I dont think we enabled it yet
Collaborator
Author
Merge activity
|
maxy-shpfy
force-pushed
the
08-16-fix_context_panel_on_node_dragging
branch
from
39e01e3 to
fe5234a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/Shopify/oasis-frontend/issues/202
This PR improves performance and code quality through several optimizations:
isDraggingcheck in TaskNodeCard that was causing performance issuesuseToastNotificationhook withuseCallbackto prevent unnecessary re-rendersType of Change
Checklist
Test Instructions
Screen Recording 2025-12-04 at 3.33.30 PM.mov (uploaded via Graphite)