bugsnag: chain-aware grouping key and chain title in error list#262
Open
morgan-wowk wants to merge 1 commit into
Open
bugsnag: chain-aware grouping key and chain title in error list#262morgan-wowk wants to merge 1 commit into
morgan-wowk wants to merge 1 commit into
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
normalize_error_chain walks __cause__/__context__ and joins each level's normalized string with " <- ". This replaces the single- exception normalize_error_message call used for the grouping key so that "LauncherError <- TimeoutError" and "LauncherError <- ApiException" land in separate, stable groups rather than one per root cause. build_chain_title does the same walk but truncates each level to 80 chars and returns None for single exceptions. _before_notify uses it to override the root-cause errorClass shown in the Bugsnag error list, giving reviewers the full raise path at a glance.
morgan-wowk
force-pushed
the
bugsnag-error-chain
branch
from
6787d59 to
afad13f
Compare
morgan-wowk
changed the base branch from
bugsnag-grouping-strip-json
to
graphite-base/262
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize_error_chainwalks__cause__/__context__and joins each level's normalized string with" <- ". This replaces the single-exceptionnormalize_error_messagecall used for the grouping key so that"LauncherError <- TimeoutError"and"LauncherError <- ApiException"land in separate, stable groups rather than collapsing into one group per root cause.build_chain_titledoes the same walk but truncates each level to 80 chars and returnsNonefor single exceptions._before_notifyuses it to override the root-causeerrorClassthat Bugsnag displays in the error list, giving reviewers the full raise path at a glance without needing to open the stacktrace.