Potential fix for code scanning alert no. 20: Incomplete URL substring sanitization#3
Merged
Potential fix for code scanning alert no. 20: Incomplete URL substring sanitization#3
Conversation
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/stagehand/security/code-scanning/20
In general, fix this by parsing the URL and validating structured components (origin/hostname) instead of checking for a substring. For this case we want to confirm that the loaded page is actually on
store.steampowered.comusing the browser’s own URL parsing, not string matching.The best fix here is to replace the substring check on line 21 with a host/origin check using the standard
URLconstructor. For example:page.url().new URL(currentUrl).url.hostnametostore.steampowered.com(or, if you ever need flexibility, compareurl.origintohttps://store.steampowered.com).successflag instead ofincludes.We can implement this directly at the existing
successassignment without changing behavior elsewhere. No new imports are required becauseURLis a global in modern Node/TypeScript environments. The only change is inpackages/evals/tasks/agent/steam_games.tsaround line 21.Suggested fixes powered by Copilot Autofix. Review carefully before merging.