Conversation
…m environment values Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Repository owner
locked and limited conversation to collaborators
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/Tanker187/vite/security/code-scanning/12
In general, you should avoid concatenating filesystem paths or environment-derived values into a single shell command string. Instead, call the underlying program directly and pass dynamic parts as arguments, bypassing the shell so that special characters in paths cannot alter the command structure.
Here, the only problematic use is
const buildCommand =${viteBinPath} buildpassed to `execaCommand(buildCommand, ...)`. We can replace this with a non‑shell call to `execa` that takes `viteBinPath` as the executable and `['build']` as its argument list. That way, `viteBinPath` is never parsed by a shell; it’s used directly as a program path, and `"build"` is a separate argument. To preserve logging, we can keep a human‑readable string for error messages (e.g.const buildCommandDisplay = `"${viteBinPath}" build"``) while using the safer API for execution.Concretely in
playground/cli/__tests__/serve.ts:execainstead of (or alongside)execaCommand.if (isBuild)block, replace:const buildCommand =${viteBinPath} build`` with:execa(viteBinPath, ['build'], { ... }).buildCommandvariable.No changes are needed in
playground/vitestSetup.ts.Suggested fixes powered by Copilot Autofix. Review carefully before merging.