Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

🐛 Fix no res file in VMs#123

Merged
TanmayPatil105 merged 3 commits intomainfrom
fix-resolution
Feb 22, 2023
Merged

🐛 Fix no res file in VMs#123
TanmayPatil105 merged 3 commits intomainfrom
fix-resolution

Conversation

@TanmayPatil105
Copy link
Owner

Closes

Closes #122

Changes

  • Added resCheck function
  • Ordered function definition in fetch.h and fetch.cpp
  • Add ascii/Makefile to .gitignore

Copy link
Collaborator

@youpong youpong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple is better.

bool resCheck()
 {
-     if (Path::of("/sys/class/graphics/fb0/modes"s).isRegularFile())
-     {
-         return true;
-     }
-     return false;
+    return Path::of("/sys/class/graphics/fb0/modes"s).isRegularFile(); 
 }

@TanmayPatil105
Copy link
Owner Author

Done!

@TanmayPatil105 TanmayPatil105 merged commit 1fd60e2 into main Feb 22, 2023
@TanmayPatil105 TanmayPatil105 deleted the fix-resolution branch February 22, 2023 14:09
@youpong
Copy link
Collaborator

youpong commented Feb 22, 2023

Good catch!
It was omitted from the work on the pull request #118 that adding ascii/Makefile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error while printing Resolution in VM

2 participants