Skip to content
This repository was archived by the owner on Sep 3, 2024. It is now read-only.

Copy the procfetch.gif#96

Merged
TanmayPatil105 merged 1 commit intoTanmayPatil105:mainfrom
youpong:fix-#95
Feb 10, 2023
Merged

Copy the procfetch.gif#96
TanmayPatil105 merged 1 commit intoTanmayPatil105:mainfrom
youpong:fix-#95

Conversation

@youpong
Copy link
Collaborator

@youpong youpong commented Feb 9, 2023

Description

Fix Issue #95

@codecov-commenter
Copy link

Codecov Report

Merging #96 (51bbbaf) into main (001ab9f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   27.04%   27.04%           
=======================================
  Files           4        4           
  Lines         403      403           
=======================================
  Hits          109      109           
  Misses        294      294           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@TanmayPatil105
Copy link
Owner

Are you sure this will fix it?
It will only fix when generating docs locally.
Here we are running doxygen and not make docs!

@youpong
Copy link
Collaborator Author

youpong commented Feb 9, 2023

As you point out, this fix is limited to improvements only when you are generating documents locally. So the problem still remains.

@TanmayPatil105
Copy link
Owner

Should I can make changes here inorder to fix it?

    - name: Install Doxygen
      run: sudo apt-get install doxygen graphviz -y
      shell: bash

    - name: Configure
      run: ./configure
      shell: bash

    - name: Generate Doxygen Documentation
      run: make docs
      shell: bash

@youpong
Copy link
Collaborator Author

youpong commented Feb 10, 2023

I think that changes would help to fix it.

@TanmayPatil105 TanmayPatil105 merged commit 5fb527a into TanmayPatil105:main Feb 10, 2023
@TanmayPatil105
Copy link
Owner

It is still not fixed ig!

@TanmayPatil105
Copy link
Owner

Let me try different Workflows to see how we can fix it.

@TanmayPatil105
Copy link
Owner

My bad, I didn't release the updated version! LOL

@TanmayPatil105
Copy link
Owner

Fixed 🔧!

@youpong youpong deleted the fix-#95 branch February 12, 2023 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants