Step material consistency #88
Merged
+15
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug 1: In step.blade.php, distinguish between intentionally text-only steps
(material_type is null) and steps with deleted material (material_type is set
but material record doesn't exist). Now shows error for deleted material
regardless of whether text exists.
- Bug 2: In MorphToSelectWithCreate.php, change material_id from nullable() to
requiredWith('material_type') to prevent invalid state where material_type is
selected but material_id is null.
andreia
merged commit cd81152
into
allow_nullable_material_on_step
4 of 8 checks passed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <x-filament-lms::next-button :fixed="false" /> | ||
| @if (is_null($step->material_type)) | ||
| {{-- Intentionally text-only step: show the next button --}} | ||
| <x-filament-lms::next-button /> |
There was a problem hiding this comment.
Empty steps no longer display error message
Low Severity
The old code showed an error message when a step had no material AND no text content. The new code assumes material_type being null indicates an intentional text-only step, but it no longer verifies text actually exists. Since the text field in StepResource isn't required, steps with material_type = null and no text will display only a next button with no visible content, instead of showing the error message the old code provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR addresses two issues related to material handling in steps:
step.blade.phpview now distinguishes between intentionally text-only steps (wherematerial_typeis null) and steps where material was deleted (wherematerial_typeis set but the material record is missing). An error message is now displayed when material is missing but amaterial_typewas specified.MorphToSelectWithCreatecomponent now usesrequiredWith('material_type')for thematerial_idfield. This prevents users from selecting amaterial_typewithout also selecting an actual material item, ensuring data consistency.Note
Low Risk
Low risk: view logic and form validation tweaks to prevent inconsistent step/material states; main risk is stricter validation blocking previously-saved partial entries.
Overview
Improves step material consistency by treating
material_type = nullas an intentionally text-only step (shows only the next button) while showing an explicit error state whenmaterial_typeis set but the linked material record is missing.Tightens the step material form by making
material_idrequiredWith('material_type'), preventing users from selecting a material type without choosing an actual material.Written by Cursor Bugbot for commit d2b7e39. This will update automatically on new commits. Configure here.