trim workaround (issue #77)#78
Merged
Tarmil merged 3 commits intoTarmil:masterfrom Nov 21, 2020
pchalamet:feature/trim-workaround
Merged
trim workaround (issue #77)#78Tarmil merged 3 commits intoTarmil:masterfrom pchalamet:feature/trim-workaround
Tarmil merged 3 commits intoTarmil:masterfrom
pchalamet:feature/trim-workaround
Conversation
Contributor
Author
|
Merged main. |
Owner
|
After testing some more, it seems that only the calls parameterized by |
Contributor
Author
|
Thanks for the feedback. Good to know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for issue #77 as describe in dotnet/runtime#43222 (comment)
Publish with trimming now works as expected.
This PR convert Serializer.Serialize<> and Serializer.Deserialize<> to non-generic counterparts.
NOTE: no performance impact has been done. This probably ought be checked (downcast
:?>used).