Merged
Conversation
hyoseong-Choi
added
✨ feature
parkjaehak
reviewed
Jan 21, 2025
Comment on lines
33
to
39
| this.taskCode = taskEntity.getTaskCode(); | ||
| this.mainCategory = taskEntity.getCategory().getMainCategory().getName(); | ||
| this.subCategory = taskEntity.getCategory().getName(); | ||
| this.status = taskEntity.getStatus().getName(); | ||
| this.status = taskEntity.getStatus().getStatusName().name().toLowerCase(); | ||
| this.processor = taskEntity.getProcessor().getNickname(); | ||
| this.createdAt = taskEntity.getCreatedAt().toLocalDate(); | ||
| } |
Collaborator
There was a problem hiding this comment.
현재 status 엔티티는 삭제되었고 taskEntity.getTaskStatus() 를 통해 상태를 가져올 수 있을 것 같습니다.
develop 브랜치 rebase 해주신 후 수정 부탁드리겠습니다~
parkjaehak
approved these changes
Jan 21, 2025
Comment on lines
+26
to
+29
| @GetMapping("/task/statistics/task-processed-by-period") | ||
| public Map<String, Long> aggregatePeriodTaskProcess(@RequestParam String period) { | ||
| return periodTaskProcessUsecase.periodTaskProcessAggregate(period); | ||
| } |
Collaborator
There was a problem hiding this comment.
응답시 따로 상태코드는 안보내는 것으로 보이는데 Http 상태 코드가 리턴되어야 하지 않을까 싶습네요.
Collaborator
Author
There was a problem hiding this comment.
응답시 따로 상태코드는 안보내는 것으로 보이는데 Http 상태 코드가 리턴되어야 하지 않을까 싶습네요.
저희 공통 응답 양식 클래스 올라오면 한번에 바꾸려고 했는데 혹시 그거 사용 안하기로 했었나요?
Collaborator
There was a problem hiding this comment.
네넵 성공의 경우에는 http 상태코드와 응답결과만 보내주면 될 것 같습니다.
{
"결과":"result"
}
오류처리에 대한 부분만 처리하기로 했습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #46