Skip to content

feature/update-project-status#134

Merged
mdawoud27 merged 4 commits into
mainfrom
feature/133/update_project_status
Apr 12, 2025
Merged

feature/update-project-status#134
mdawoud27 merged 4 commits into
mainfrom
feature/133/update_project_status

Conversation

@mdawoud27
Copy link
Copy Markdown
Contributor

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #133

@mdawoud27 mdawoud27 added documentation Improvements or additions to documentation enhancement New feature or request feature For new feature labels Apr 12, 2025
@mdawoud27 mdawoud27 requested a review from Copilot April 12, 2025 17:10
@mdawoud27 mdawoud27 self-assigned this Apr 12, 2025
@mdawoud27 mdawoud27 linked an issue Apr 12, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (2)

src/controllers/project.controller.js:539

  • [nitpick] Consider extracting the valid status values into a shared constant or configuration to improve consistency and reusability if similar validations are used elsewhere.
const validStatuses = [ 'PLANNING', 'ACTIVE', 'ON_HOLD', 'COMPLETED', 'CANCELED' ];

src/controllers/project.controller.js:512

  • Ensure that the new updateProjectStatus endpoint is adequately covered by unit and integration tests, including tests for invalid status values and permission checks.
export const updateProjectStatus = async (req, res, next) => {

@mdawoud27 mdawoud27 merged commit 6a91ea8 into main Apr 12, 2025
11 checks passed
@mdawoud27 mdawoud27 deleted the feature/133/update_project_status branch April 12, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request feature For new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Update the status of a project

2 participants