feature/create-task#150
Merged
Merged
Conversation
mdawoud27
added
documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new feature for creating tasks, with updates to validation, routing, and controller logic to support task creation, along with corresponding documentation changes.
- Added a Joi-based validation schema for task creation
- Implemented a new POST endpoint for task creation and updated the task controller with additional validations and order computation
- Fixed minor validation call issues in authentication controllers and updated project documentation
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/validations/task.validation.js | Introduces a Joi schema for task creation validations |
| src/routes/task.routes.js | Adds a new POST route for creating tasks |
| src/index.js | Updates to include the task routes and removal of body-parser usage |
| src/controllers/task.controller.js | Updates task creation logic, including validations, permission checks, and order computation |
| src/controllers/project.controller.js | Removes outdated department verification logic |
| src/controllers/auth.controller.js | Fixes validation function calls to pass the request body correctly |
| README.md | Documents the new task creation endpoint |
Files not reviewed (1)
- src/docs/swagger.json: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (required)
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Related Issue
Closes #149