feature/update-task#152
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new feature to update tasks by adding an update validation schema, new update route, and a corresponding controller function. The key changes include:
- Introducing the updateTaskValidation schema with validations for task properties.
- Adding a new PUT route for updating tasks.
- Implementing the updateTask controller with validation, permission checks, and circular dependency handling.
- Updating README documentation to include the update route.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/validations/task.validation.js | Added updateTaskValidation schema with various field validations. |
| src/routes/task.routes.js | Registered a new PUT route for task updates. |
| src/controllers/task.controller.js | Implemented updateTask controller to handle task updates. |
| README.md | Updated API documentation to include instructions for updating a task. |
Files not reviewed (1)
- src/docs/swagger.json: Language not supported
Comments suppressed due to low confidence (1)
src/controllers/task.controller.js:373
- The updateTaskValidation schema includes additional fields ('rate', 'order') that are not extracted or updated in the controller. Consider either handling these fields in the updateTask function or removing them from the validation schema to maintain consistency.
const { title, description, priority, sprintId, assignedTo, dueDate, estimatedTime, parentId, labels } = req.body;
… into feature/151/update_task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (required)
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Related Issue
Closes #151