Skip to content

Feat/59/get user by#62

Merged
Kimoo193 merged 9 commits into
mainfrom
feat/59/get-user-by-id
Apr 4, 2025
Merged

Feat/59/get user by#62
Kimoo193 merged 9 commits into
mainfrom
feat/59/get-user-by-id

Conversation

@Kimoo193
Copy link
Copy Markdown
Contributor

@Kimoo193 Kimoo193 commented Apr 4, 2025

PR Checklist (required)

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

Related Issue

Closes #59

@Kimoo193 Kimoo193 requested a review from mdawoud27 April 4, 2025 16:08
@Kimoo193 Kimoo193 linked an issue Apr 4, 2025 that may be closed by this pull request
@Kimoo193 Kimoo193 requested review from Copilot and removed request for mdawoud27 April 4, 2025 16:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

README.md:35

  • [nitpick] The description 'Get a specific Users' is grammatically incorrect and the route mismatches the actual endpoint; consider updating it to 'Get a specific User' and ensure the route matches '/api/users/:id'.
+- **Get a specific Users**: GET `/api/Users/:userId`

Comment thread src/validations/user.validation.js Outdated
Comment thread src/controllers/user.controller.js Outdated
Comment thread src/controllers/user.controller.js Outdated
@Kimoo193 Kimoo193 requested a review from Copilot April 4, 2025 16:11
Kimoo193 and others added 2 commits April 4, 2025 18:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

README.md:35

  • The endpoint is documented as /api/Users/:userId, which does not match the actual route /api/users/:id. Update the documentation for consistency.
- **Get a specific Users**: GET `/api/Users/:userId`

Comment thread src/validations/user.validation.js Outdated
Comment thread src/controllers/user.controller.js Outdated
Comment thread src/controllers/user.controller.js Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Kimoo193 Kimoo193 merged commit 54514b1 into main Apr 4, 2025
11 checks passed
@Kimoo193 Kimoo193 deleted the feat/59/get-user-by-id branch April 4, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get a specific user by id

2 participants