enhancement/organization-apis

[mdawoud27]

PR Checklist (required)

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines.

• Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation changes
• Other... Please describe:

Related Issue

Closes #29

[Copilot]

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Files not reviewed (1)

• src/docs/swagger.json: Language not supported

Comments suppressed due to low confidence (2)

src/routes/organization.routes.js:38

• Removal of verifyAdminPermission middleware from the update route might allow unauthorized organization updates. Please confirm that this change is intentional and that updateOrganization is sufficiently protected by other mechanisms.

verifyAdminPermission,

src/middlewares/verifyUserPermission.middleware.js:2

• The removal of the email check (req.user.email === req.params.email) may reduce flexibility in permission verification. Confirm that this simplified logic meets all intended use cases.

if (req.params.id === req.user.id || req.user.role === 'ADMIN') {

[Copilot]

Potential bug: If 'upload' is not found in the URL pathname, uploadIndex will be -1 leading to incorrect publicId extraction. Consider validating uploadIndex before slicing the parts array.

Suggested change

	const uploadIndex = parts.findIndex((part) => part === 'upload');
	const uploadIndex = parts.findIndex((part) => part === 'upload');
	if (uploadIndex === -1) {
	throw new Error('Invalid image URL: "upload" segment not found in pathname');
	}

[Copilot]

Potential bug: The boolean conversion for filters.isVerified does not explicitly handle false-equivalent values (e.g., 'false', '0'). Consider expanding the logic to clearly determine both true and false conditions.

Suggested change

	where.isVerified = ['true', '1', true].includes(filters.isVerified);
	if (['true', '1', true].includes(filters.isVerified)) {
	where.isVerified = true;
	} else if (['false', '0', false].includes(filters.isVerified)) {
	where.isVerified = false;
	}

[Copilot]

Bug: The membership check only verifies that there are users in the organization, rather than confirming that the current user is a member. Consider checking if organization.users includes the current user's id.

Suggested change

	const isMember = organization.users.length > 0;
	const isMember = organization.users.some(
	(user) => user.id === req.user.id,
	);