feature/logout#79
Merged
Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- prisma/migrations/20250406115517_logout/migration.sql: Language not supported
- prisma/schema/models/user.model.prisma: Language not supported
Comments suppressed due to low confidence (1)
src/middlewares/auth.middleware.js:11
- The decoded token is not attached to req, causing subsequent handlers (like logout) to lack user information. Consider setting req.user = decoded after verifying the token.
const decoded = jwt.verify(token, process.env.JWT_ACCESS_SECRET);
| export const logout = async (req, res, next) => { | ||
| try { | ||
| // Get user ID from the authenticated request | ||
| const userId = req.user.id; |
There was a problem hiding this comment.
The logout function assumes req.user is present, but the verifyAccessToken middleware does not attach the decoded token to req. This may lead to a runtime error if req.user is undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist (required)
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines.
Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
Related Issue
Closes #78