-
Notifications
You must be signed in to change notification settings - Fork 104
Closes #2148 make the readme more appealing #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a554b81 to
0d0abf5
Compare
c3073a5 to
61cffed
Compare
|
The README in this PR looks way better than before! What is the rule for spelling entities? In this PR, some entities are spelled in caps (e. g. WORKBASKET). Some other entities are lowercase (e. g. workbasket) or uppercase (e. g. Workbasket). How should TASKANA be spelled? As "Taskana" or "TASKANA"? Are the spelling questions relevant, or are the incosistencies ok? |
|
Hi @arolfes , this PR looks really helpful to me. What needs to be done before integrating it? |
|
Hallo @ryzheboka ,
The review is missing. Can you do a review? When you approve the changes, you can merge it or I will.
By the way: I took your Image. :) Best regards |
|
Hello @ryzheboka
You are absolutely right, TASKANA should always be capitalised as a name in the documentation. |
|
Hello @ryzheboka
Can you talk to Holger about it? I know in which case you write everything in capital letters and in which case in small letters. If he thinks it's OK, then we leave it as it is and merge the thing. I believe that anyone who stumbles across an inconsistency can fix it. |
|
Hi @arolfes , I asked @holgerhagen about uppercase vs lovercase. He said that we agreed to start every entity in uppercase. In the following example, "task" and "tasks" need to start in uppercase: Could you adjust this? Alternatively, I could add a commit to this branch that adjusts it. |
Hi @ryzheboka , It would be very helpful for me if you can do it. I trust you there. :) I gave you write permissions to this branch I force pushed my branch. So you need do a |
ecc23ae to
71185f0
Compare
|
The branch is rebased. I also adjusted the capitalization. @arolfes, could you check if everything looks ok? Then we can integrate this PR |
Good Morning, I think we can merge it |
71185f0 to
f3fb37f
Compare
|
Hi @arolfes, |
|
Hello @ryzheboka ,
I totally agree on this topic. the images look a bit strange :) White is fine. So it should work also in "normal" mode :)
|
f3fb37f to
de218a5
Compare
de218a5 to
6c33523
Compare

Only readme and images therefore no sonarcloud.
The diff of the readme is very large. You can find a rendered version here: https://github.com/arolfes/taskana/blob/2148-readme/README.md
Release Notes:
For the submitter:
Verified by the reviewer: