BUGFIX-2737 to Main #49
Merged
+735
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Dev Board Ticket https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2737 ## Changes - Restored custom field support across schemas (CustomNode/Edge/Zone) while aligning required fields with original behavior. - Relaxed edges/zones global required lists to let custom features omit `highway` (kept in branch-specific schemas). - Enhanced 0.2 compatibility guard: allow `ext:` on nodes, block custom content per dataset with specific messages (e.g., Custom Edge/Point/Polygon), and reject non-point `ext:`. - Added schema parity tests and fixtures for custom feature branches and 0.2 vs 0.3 behavior, including guard reason checks. - Improved diff tooling/reporting and parity fixtures to cover custom scenarios. ## Testing - Added 14 new test cases (all in tests/test_schema_parity.py) and 30 new fixture files under tests/schema/fixtures (covering nodes/edges/lines/points/polygons/zones).
MashB
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Board Ticket
https://dev.azure.com/TDEI-UW/TDEI/_workitems/edit/2737
Changes
highway(kept in branch-specific schemas).ext:on nodes, block custom content per dataset with specific messages (e.g., Custom Edge/Point/Polygon), and reject non-pointext:.Testing
tests/test_schema_parity.py) and 30 new fixture files undertests/schema/fixtures(covering nodes/edges/lines/points/polygons/zones).