Update stage with changes to dev post-demo. #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Parameterization to prepare for deployment to prod * Prepare prod image build
* Parameterization to prepare for deployment to prod * Prepare prod image build * Update build.yaml
Collaborator
|
These look like changes I made prior maybe they got lost in dev when somebody accidentally resolved a merge conflict maybe? What was your intended change re: "avoiding hitchhhikers"? |
Collaborator
|
And I believe you can merge these too? Feel free unless you want my review? |
Collaborator
Author
just wanted to check with you that the build.yaml changes were good to hitchhike with my frontend submodule update since things did get a little wooly there. thanks for confirming! |
Collaborator
|
I see, no worries--yeah, just compare that file to stage or prod, they should be the same there too? If you want a second check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environments got out of sync during demo prep, this PR hopes to re-align our environments so we can push PRs through dev -> stage -> prod without hitchhikers.