Skip to content

feat: add local image mount access#140

Merged
SimsonW merged 2 commits intomasterfrom
feat/local_file_api
May 29, 2024
Merged

feat: add local image mount access#140
SimsonW merged 2 commits intomasterfrom
feat/local_file_api

Conversation

@Dttbd
Copy link
Copy Markdown
Contributor

@Dttbd Dttbd commented May 28, 2024 •
edited by jameszyao
Loading

Pull Request

PR Description

add local image and file upload path mounting.

Type of Change

  • Bug fix
  • New feature
  • Performance enhancement
  • Code refactor
  • Documentation update
  • Other, please describe:

Checklist

Before submitting this PR, please make sure:

  • I have read the CONTRIBUTING.md guidelines.
  • I have tested my changes locally to ensure they are effective.
  • I have updated the necessary documentation (if applicable).

@Dttbd Dttbd requested review from jameszyao and taskingaijc May 28, 2024 13:20
@Dttbd Dttbd force-pushed the feat/local_file_api branch from 3a8d800 to f2075dd Compare May 28, 2024 13:28
@Dttbd Dttbd force-pushed the feat/local_file_api branch from f2075dd to ad9db27 Compare May 28, 2024 13:52
@Dttbd Dttbd force-pushed the feat/local_file_api branch from ad9db27 to 516c078 Compare May 29, 2024 02:53
@jameszyao jameszyao removed the request for review from taskingaijc May 29, 2024 03:09
@Dttbd Dttbd force-pushed the feat/local_file_api branch from a1b0473 to 64a576c Compare May 29, 2024 04:16
@Dttbd Dttbd force-pushed the feat/local_file_api branch from 1fd1705 to 801fbc1 Compare May 29, 2024 07:07
@jameszyao jameszyao force-pushed the feat/local_file_api branch from dcd4d89 to 9bdf1aa Compare May 29, 2024 10:37
@taskingaijc taskingaijc force-pushed the feat/local_file_api branch from 8d201ab to 036f3c6 Compare May 29, 2024 11:08
@taskingaijc taskingaijc force-pushed the feat/local_file_api branch from 036f3c6 to c021e6a Compare May 29, 2024 11:30
@taskingaijc taskingaijc force-pushed the feat/local_file_api branch from c021e6a to b21ffb8 Compare May 29, 2024 11:45
@taskingaijc taskingaijc force-pushed the feat/local_file_api branch from b21ffb8 to 2d859fa Compare May 29, 2024 12:07
jameszyao
jameszyao approved these changes May 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jameszyao jameszyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SimsonW
SimsonW approved these changes May 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SimsonW SimsonW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jameszyao jameszyao jameszyao approved these changes

+1 more reviewer

@SimsonW SimsonW SimsonW approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dttbd @jameszyao @SimsonW @taskingaijc