Fix: TaurusTLS_NTLM untyped procedural var assignment#119
Merged
JPeterMugaas merged 1 commit intoTaurusTLS-Developers:mainfrom Oct 4, 2025
Merged
Conversation
TaurusTLS_NTLM assignd several variables with untyped pointers and compiler can't generate wrong type assignemnt error. Even the assignemnt is correct it may introduce errors in the future if procedural types needs to be changed.
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Bito
This pull request fixes a bug in the TaurusTLS_NTLM unit by correcting untyped procedural variable assignments for NTLM functions. The changes ensure proper assignment of function pointers without the unnecessary use of the '@' operator, enhancing the reliability of NTLM functionality.