integer overflow hardening in input-derived arithmetic#160
Merged
Taywee merged 2 commits intoMay 12, 2026
Merged
Conversation
Owner
|
Not bad. I don't see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves the safety of integer arithmetic in
args.hxx, focusing on computations derived from external or user-controlled input.It introduces reusable checked-arithmetic helpers (
SafeAddandSafeMultiply) to explicitly validate boundary conditions before performing arithmetic operations, preventing silent integer overflow and wraparound.These helpers are applied to key input-sensitive code paths, including formatting and parsing logic:
Changes in Core Logic
Wrap(), width calculation arithmetic is hardened to prevent overflow during formatting operations.ArgumentParser::Parse(), bash completion index arithmetic is updated to use checked addition instead of unchecked integer operations.Testing
A regression test suite (
test/safe_arithmetic.cxx) is also added to validate correctness under edge cases, including:Overall, this change improves the robustness and auditability of integer arithmetic by centralizing overflow protection into reusable utilities and applying them consistently across input-derived computation paths.