Skip to content

Incorrect values for input sources for Odyssey G9 OLED #2

@dlpullen

Description

@dlpullen

Currently, the code limits the "valid" input source values to 4 values in the handleSetSource function in http.cpp.

These values are:

  • 0x0f
  • 0x10
  • 0x11
  • 0x12

The Odyssey G9 OLED is apparently a little different. It only has 3 inputs and the values are:

  • 0x05 (Full-size HDMI aka HDMI 1)
  • 0x06 (Mini HDMI aka HDMI 2)
  • 0x0f (Display Port)

I would propose to either remove the check in line 108 in http.cpp or to add these values to the checked items. I am unsure how much variety there is across different monitors that might benefit from hardwareddc.

As a quick point of comparison, I have some Dell 2721QS monitors with fantastic ddc support. So, no need for hardwareddc for them. But, There input values are:

  • 0x0f (Display Port)
  • 0x11 (HDMI 1)
  • 0x12 (HDMI 2)

These are in better alignment (a subset) with the values you already have setup in the if statement.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions