This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Merged
Conversation
rlanzafame
suggested changes
Dec 9, 2024
Member
rlanzafame
left a comment
rlanzafame
left a comment
There was a problem hiding this comment.
Great! Unfortunately I probably should have told you to use MyST admonitions rather than HTML tags, sorry. Luckily it is an easy fix, and good practice. Some comments and tips:
- see this page where it explains that raw HTML is generally not advised
- see this page which shows the preferred way to include images.
- experiment with the build locally and feel free to adjust the width/height to reach a formatting/image size that you think is good
- once you commit more changes to this branch it will show up in the PR conversation and you can then re-request a review from me!
tshiya731
requested review from
rlanzafame
and removed request for
rlanzafame
Collaborator
Author
|
Hi Robert, I changed all the html into MyST at the final commit: fix by MyST. @rlanzafame |
rlanzafame
approved these changes
Dec 10, 2024
Member
|
great! |
rlanzafame
added a commit
that referenced
this pull request
Mar 22, 2025
* Update requirements.txt * Update _config.yml to fix the Sympy reference * Update 01.ipynb Add some markdowns to align the errors and debugging section to MUDE corresponding part * Update sympy.ipynb please ignore the first pull request, which changed the config.yml. config is completely fine and i just forget to add the reference. after adding the reference it should be completely fine to show the reference part. * Update _config.yml (#13) * Update _config.yml to fix the Sympy reference * Update 01.ipynb Add some markdowns to align the errors and debugging section to MUDE corresponding part * Update sympy.ipynb please ignore the first pull request, which changed the config.yml. config is completely fine and i just forget to add the reference. after adding the reference it should be completely fine to show the reference part. * Update _config.yml to make it the original * First branch (#14) * Update _config.yml (#17) * Update 01.ipynb (#18) * Fix figures (#19) * fix figures * fix 04 * MyST * myst_try * fix by MyST * simple bug fix (#25) * fix bugs for book6 * fix typo in chapter 5 * matrix operator fix wrong matrix operator in chapter 5 * matrix operator fix * H5p test(only changed Exercise 1.2.2) (#22) * exercise transition * test * update readme * create docs subdir and add old stuff * describe quiz convention * apply quiz convention * book1_exercises_updata * remove-input * remove-input * remove_input --------- Co-authored-by: Robert Lanzafame <R.C.Lanzafame@tudelft.nl> * Chapter2 h5p (#27) * h5p--chapter2 * add notes to h5p * chapter1- typo fix (#28) * Chapter5 h5p (#29) * chapter5-h5p * exercise2 * bug form remove * reportbug-setup * intro comments and filename formatting * intro text: adjust additional resources info * update feedback instructions * toolbox-calculator update * fix intro * better name * get sphinx-thebe from github --------- Co-authored-by: Tom van Woudenberg <t.r.vanwoudenberg@tudelft.nl> Co-authored-by: tshiya731 <tshiya05@gmail.com> Co-authored-by: tshiya731 <152382463+tshiya731@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main changes I made are:
@rlanzafame