Fix worldSpace_linkAt not choosing closest Link#46
Merged
EdNutting merged 1 commit intoTeachingTechnologistBeth:masterfrom Sep 2, 2020
Merged
Fix worldSpace_linkAt not choosing closest Link#46EdNutting merged 1 commit intoTeachingTechnologistBeth:masterfrom
EdNutting merged 1 commit intoTeachingTechnologistBeth:masterfrom
Conversation
Collaborator
|
Does this mean that if I click in completely empty space far away from any links, I might end up selecting something that is far away from where I clicked? My instinct says a better solution is to have the search distance as a variable (instead of fixed 15) and scale it according to the current zoom level (with 15 being the base-case at the current default zoom). |
Contributor
Author
|
I'm not entirely familiar with the codebase, but isn't this function in worldspace anyway, so we shouldn't need to worry about zoom level? |
Collaborator
|
Ah I see, sorry I misunderstood the code earlier. This looks good to me then (sorry, long day syndrome :p ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45