Merged
Conversation
samxu01
added a commit
that referenced
this pull request
Feb 2, 2026
samxu01
pushed a commit
that referenced
this pull request
Apr 3, 2026
MubaiHua
pushed a commit
that referenced
this pull request
Apr 20, 2026
3 tasks
samxu01
added a commit
that referenced
this pull request
May 4, 2026
…291) All three load-bearing prereqs ran as a research spike. Verdicts: (i) SHA256SUMS — ✅ Available. iOfficeAI/OfficeCLI v1.0.70 publishes the artifact at github.com/.../releases/download/v1.0.70/SHA256SUMS (710 bytes). Use upstream verification path. (ii) Per-agent skill scoping — ❌ Deeper backend change required. Three surfaces all need work: 1. backend/routes/skills.ts:279-307 — store agent metadata but drop agentName when calling sync hook 2. backend/services/agentProvisionerService.ts:424-549 — syncOpenClawSkillsLocal queries ALL pod skills, ignores per-agent scope. buildScopedSkillKey exists but is unused in the sync path 3. ${WORKSPACE_ROOT}/${accountId}/skills/ — accountId uses instanceId only for openclaw (collision-prone); import path bypasses resolveOpenClawAccountId Phase 4 splits into 4a (frontend) + 4b (backend). PR estimate finalized at ~7. (iii) Workspace-boundary helper —⚠️ Helper at path-policy.ts:105 is high quality (rejects .., resolves symlinks, cross-platform) but NOT exported from plugin-sdk. ~10-line export refactor absorbs into Phase 0b. Surprise: acpx_run has zero path validation today. Recommendation: defer hardening — ADR-005 Stage 3 is retiring acpx_run anyway. Track deprecation timeline; revisit if it slips past 90 days. Closes open questions #1 (yes, import does push to PVC; the per-agent scoping inside that path is what's missing), #11, #12, #13. Adds new question #14 (acpx_run hardening — defer). Updated §"Relationship to ADR-005" naming note to reflect that commonly_open_dm + agent-dm pod type both shipped (per CLAUDE.md update). A2A-via-DM is now two shipped primitives, not just the wrapper-agent pattern. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samxu01
added a commit
that referenced
this pull request
May 4, 2026
Per the project's "no OpenClaw coupling" feedback rule, the ADR was still framing kernel-layer concerns relative to acpx_run (a deprecated runtime detail). Cleanup: - Phase 0b smoke test: runtime-agnostic. Unit-level test against commonly_attach_file directly with a fixture file; integration test where the agent produces the file by whatever mechanism its runtime offers (out of scope). - Invariant 4: points at the helper's actual home (plugin-sdk/path-policy) instead of "the helper acpx_run uses." - Phase 0a (iii): drop the "acpx_run has zero validation" surprise framing — it's a deprecated runtime detail, not this ADR's concern. - Open question #14 withdrawn (whether to harden acpx_run belongs in ADR-005's deprecation track, not here). - §Relationship to ADR-005 rewritten as "kernel-first, runtime- agnostic" — drops the multi-section composition-with-acpx-deprecation discussion, replaces with a tighter framing: ADR-013 ships kernel verbs that don't care which runtime ran the binary. - §What this unlocks bullet reframed from "acpx_run deprecation gets easier" to "Runtime-neutral file delivery" — same point, no coupling. Remaining acpx_run mentions are confined to resolved/withdrawn open questions (#12, #14) and the revision history — appropriate audit trail for the framing being corrected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run lintCI=true npm test -- -w 0