feat(v2): rich artifacts in pod inspector — paste Notion/Drive/Figma/GitHub/Zoom#266
Merged
feat(v2): rich artifacts in pod inspector — paste Notion/Drive/Figma/GitHub/Zoom#266
Conversation
9 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+99
to
+118
| // Reject anything that isn't a real http(s) URL — guards against `javascript:` | ||
| // or `data:` schemes ending up in an <a href> in the inspector. WeChat QR-code | ||
| // links are exempt because their primary surface is qrCodePath, not href. | ||
| const isSafeHttpUrl = (rawUrl: string): boolean => { | ||
| try { | ||
| const u = new URL(rawUrl); | ||
| return u.protocol === 'http:' || u.protocol === 'https:'; | ||
| } catch { | ||
| return false; | ||
| } | ||
| }; | ||
|
|
||
| // URL → ExternalLinkType. Used when the client passes type='auto' (or omits | ||
| // type with a URL present) so the v2 inspector "+ Add" flow is paste-and-go. | ||
| // Match the most specific host first; everything unknown falls back to | ||
| // 'other_link'. Keep this in sync with the enum in models/ExternalLink.ts. | ||
| const detectLinkType = (rawUrl: string): string => { | ||
| if (!rawUrl) return 'other_link'; | ||
| let host = ''; | ||
| let pathname = ''; |
| } | ||
| if (host === 'youtube.com' || host.endsWith('.youtube.com') || host === 'youtu.be') return 'youtube'; | ||
| if (host === 'loom.com' || host.endsWith('.loom.com')) return 'loom'; | ||
| if (host.includes('discord.com') || host.includes('discord.gg')) return 'discord'; |
| if (host === 'loom.com' || host.endsWith('.loom.com')) return 'loom'; | ||
| if (host.includes('discord.com') || host.includes('discord.gg')) return 'discord'; | ||
| if (host === 't.me' || host.endsWith('.telegram.org')) return 'telegram'; | ||
| if (host.includes('groupme.com')) return 'groupme'; |
| if (url && !isSafeHttpUrl(url)) return res.status(400).json({ message: 'URL must be http or https' }); | ||
| const name = (rawName && rawName.trim()) || (url ? deriveLinkName(url) : ''); | ||
| if (!name) return res.status(400).json({ message: 'Missing name' }); | ||
| const pod = await Pod.findById(podId) as { createdBy?: { toString: () => string }; members?: Array<{ toString: () => string }>; externalLinks?: unknown[]; save: () => Promise<void> } | null; |
7 tasks
samxu01
force-pushed
the
feat/v2-rich-artifacts-samxu
branch
from
6775347 to
88bf7ec
Compare
…GitHub/Zoom Extend ExternalLink enum with notion, google_doc/sheet/slides/drive, figma, zoom, gmail, github_pr/issue/repo, youtube, loom, other_link. Existing chat-bridge types untouched. Add detectLinkType(url) host/path matcher and deriveLinkName(url) so the v2 add-link flow is paste-and-go (one URL field, no type picker). Relax POST /api/pods/external-link from owner-only to any pod member — multi-member pods could not add links before. Inspector "+ Add" toggle in Artifacts section, per-type icon glyph (N, GD, FG, PR, …) and humanized kind labels. Reject javascript:/data:/file:/non-URL strings server-side with 400; inspector wraps <a href> in safeHref() for defense-in-depth on legacy rows. Tests: 44/44 — 27 route, 17 model. Detect cases for Notion (apex + subdomain), Figma, Zoom, Drive, youtu.be, Loom, fallback. 4 unsafe-URL rejection cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samxu01
force-pushed
the
feat/v2-rich-artifacts-samxu
branch
from
88bf7ec to
9ffbc75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #265 from samxu01 account.
Summary
ExternalLinkenum with 13 new URL kinds:notion,google_doc/sheet/slides/drive,figma,zoom,gmail,github_pr/issue/repo,youtube,loom,other_link. Existing chat-bridge types untouched.detectLinkType(url)host/path matcher andderiveLinkName(url)so the v2 add-link flow is paste-and-go (one URL field, no type picker).POST /api/pods/external-linkfrom owner-only to any pod member — multi-member pods could not add links before.N,GD,FG,PR, …) and humanized kind labels.javascript:/data:/file:/ non-URL strings server-side with 400; inspector wraps<a href>insafeHref()for defense-in-depth on legacy rows.Why
The Inspector's Artifacts section already existed and was reading
ExternalLink, but the type enum was a chat-bridge artifact (Discord/Telegram/WeChat/GroupMe). Empty in every demo pod. With ~80 lines of additive backend + UI work the YC demo gets real Notion/Drive/Figma/GitHub URLs in a designed surface — same substrate, same endpoints.Linked context: ADR-011 shell-first GTM track; YC demo beat 2 ("project memory is in the room with the agents") gates on artifacts being visible.
What I did NOT do
Tests
backend/__tests__/unit/routes/pods.external-links.test.js— 27 cases (was 8).backend/__tests__/unit/models/ExternalLink.test.js— 17 cases (was 2).Test plan
gh workflow run deploy-dev.yml --ref feat/v2-rich-artifacts-samxuapp-dev.commonly.me/v2, click "+ Add" in the Artifacts section🤖 Generated with Claude Code