fix(v2): reaction "+" trigger hover-only on pointer devices#379
Open
samxu01 wants to merge 1 commit into
Open
Conversation
The "+ add reaction" button was always visible next to every message, adding visual noise to chat. Gate visibility on .v2-msg:hover for pointer devices and keep it always-visible on touch (no hover affordance). :focus-within keeps the wrap visible while the picker popover is open. Reaction count badges (when count > 0) are unaffected. Closes one of four gaps from the "make it solid" goal.
samxu01
added a commit
that referenced
this pull request
May 16, 2026
The "+ add reaction" button was always visible next to every message, adding visual noise to chat. Gate visibility on .v2-msg:hover for pointer devices and keep it always-visible on touch (no hover affordance). :focus-within keeps the wrap visible while the picker popover is open. Reaction count badges (when count > 0) are unaffected. Closes 1 of 4 gaps from the "make collab bulletproof" goal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samxu01
added a commit
that referenced
this pull request
May 16, 2026
…MCP servers Verified empirically 2026-05-15 after merging #388: codex CLI 0.125.0 recognizes [mcp_servers.commonly] in config.toml (`codex mcp list` shows it enabled), but `codex exec` does NOT actually connect to or expose tools from configured MCP servers. The model's tool list stays limited to codex's built-in tools (web, image_gen, exec_command, apply_patch, ...). list_mcp_resources returns empty regardless. Per docs/MCP_INTEGRATION.md, the supported codex pattern is to wrap codex AS an MCP server (codex-as-mcp), not to have codex consume MCP servers. So #388 adds noise without effect. For Cody to actually call commonly_react_to_message autonomously, the real options are: - Switch her adapter from codex → claude-code or another MCP- consuming host (architectural decision). - Add the reaction tool to the openclaw extension's commonly_* block (separate Team-Commonly/openclaw PR; out of the "make-collab-bulletproof" goal's "no openclaw-coupled fixes" constraint). Keeping the four ship-PRs (#379/#380/#381/#382 + #383/#384/#385/#386 follow-ups) in place — they're all correct. Just removing #388. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.v2-msg__reaction-add-wrapwas always visible next to every message — visual noise in long chat threads..v2-msg:hoverfor pointer devices via@media (hover: hover).:focus-withinkeeps the wrap visible while the emoji-picker popover is open (picker buttons inside hold focus).@media (hover: none)) keeps the trigger always-visible — no hover affordance to lean on..v2-msg__reaction, rendered when count > 0) are unaffected and always visible.Closes 1 of 4 gaps from the "make collab bulletproof" goal.
Test plan
:focus-within).🤖 Generated with Claude Code