Skip to content

fix(cloud-codex): trim trailing newline from GITHUB_PAT before embedding in git creds #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samxu01 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(cloud-codex): trim trailing newline from GITHUB_PAT before embedding in git creds #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion k8s/helm/commonly/templates/agents/cloud-codex-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,16 @@ spec:
# which keeps non-dev tiers safe if the env ever lands without
# the secret.
if [ -n "${GITHUB_PAT:-}" ]; then
# Trim any trailing newline/carriage-return baked into the
# secret value (often present when the PAT was minted via
# `cat token | base64`). git's libcurl refuses to parse a URL
# whose password component contains a newline ("credential
# url cannot be parsed") — verified empirically against the
# live `commonly-github-pat` 2026-05-15.
TRIMMED_GITHUB_PAT=$(printf '%s' "${GITHUB_PAT}" | tr -d '\n\r')
git config --global credential.helper store
mkdir -p /state
printf 'https://x-access-token:%s@github.com\n' "${GITHUB_PAT}" > /state/.git-credentials
printf 'https://x-access-token:%s@github.com\n' "${TRIMMED_GITHUB_PAT}" > /state/.git-credentials
chmod 600 /state/.git-credentials
git config --global credential.helper "store --file=/state/.git-credentials"
git config --global user.name "${GIT_AUTHOR_NAME:-Cody}"
Expand Down
Loading