추천기능 메인화면 UI를 개발합니다.#328
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the MLSRecommendationFeature module, encompassing its interface, implementation, and a dedicated example application. The feature includes a main recommendation screen built with ReactorKit and custom UI components like CardListCell and RecommendationProfileView. Feedback identifies several critical issues, including an invalid iOS deployment target (26.1), a missing identifier property in CardListCell that will cause compilation errors, and an unsupported swift-tools-version. Additionally, improvements are suggested to remove debugging placeholder colors, handle system images safely without force unwrapping, and adopt UIButton.Configuration for more robust button layouts.
| @@ -0,0 +1,80 @@ | |||
| // swift-tools-version: 6.2 | |||
pinocchio22
left a comment
There was a problem hiding this comment.
고생하셨습니다!! 사용하지않는 스토리 보드 파일만 제거하면 좋을 것 같습니다 :)
📌 이슈
✅ 작업 사항
MLSRecommendationFeature 모듈 세팅
MLSAuthFeature와 동일한 3-layer 모듈 구조 세팅MLSRecommendationFeatureInterface: Factory 프로토콜 정의 (RecommendationMainFactory)MLSRecommendationFeature: Presentation + Domain + Data 구현체MLSRecommendationFeatureTesting: Mock 객체 제공용Package.swift의존성 구성 (MLSCore, MLSDesignSystem, ReactorKit, RxSwift, SnapKit 등)MLSRecommendationFeatureExample 세팅
SceneDelegate에서DIContainer를 사용하여RecommendationMainFactory등록 및 resolve로 주입UINavigationController를 root로 추천 메인 화면 진입xcodeproj 패키지 의존성 추가
MLSRecommendationFeatureExample타겟에MLSRecommendationFeature,MLSRecommendationFeatureInterface,MLSCore패키지 의존성 추가추천 메인 화면 초기 UI 구성
RecommendationMainViewController: ReactorKitView채택,bind(reactor:)구조 세팅RecommendationMainView: Header, ProfileView, grayBackgroundView, CollectionView, informationButton 레이아웃 구성RecommendationProfileView: 프로필 이미지 / 닉네임 / 직업 / 레벨 뱃지 / 수정하기 버튼 구성,ImageLoader로 프로필 이미지 비동기 로드CardListCell:CardList컴포넌트 래핑CompositionalLayoutBuilder로 구성스크린샷
👀 ETC (추후 개발해야 할 것, 참고자료 등)
RecommendationMainReactorAction / State / Mutation 구현 필요