Skip to content

[Feature] Add preview image URLs to flowerspot place list response#81

Merged
LeeHanEum merged 1 commit into
developfrom
feature/flowerspot-image-url
Jan 17, 2026
Merged

[Feature] Add preview image URLs to flowerspot place list response#81
LeeHanEum merged 1 commit into
developfrom
feature/flowerspot-image-url

Conversation

@LeeHanEum
Copy link
Copy Markdown
Collaborator

@LeeHanEum LeeHanEum commented Jan 17, 2026

🌱 관련 이슈

📌 작업 내용 및 특이 사항

  • 벚꽃 장소 조회 API 응답에 미리보기 이미지 url을 추가하였습니다.

📝 참고

  • preview 이미지는 해당 장소 이미지 목록에서 첫 번째 이미지를 불러옵니다

📌 체크 리스트

  • 리뷰어를 추가하셨나요 ?
  • 변경사항에 대해 충분히 설명하고 있나요 ?

Summary by CodeRabbit

Release Notes

  • New Features
    • Flower spot API responses now include preview image URLs for better visual identification.
    • Preview images are automatically sourced from available images for each flower spot location.
    • Image data is consistently available in both detailed views and list-view API endpoints.

✏️ Tip: You can customize this high-level summary in your review settings.

@LeeHanEum LeeHanEum self-assigned this Jan 17, 2026
@LeeHanEum LeeHanEum requested a review from char-yb as a code owner January 17, 2026 06:36
@LeeHanEum LeeHanEum linked an issue Jan 17, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 17, 2026

📝 Walkthrough

Walkthrough

The changes extend the flower spot API to include image URLs. The facade layer fetches image URLs from S3 for both single-spot and bulk queries, while the response layer adds a preview URL field representing the first image in the set.

Changes

Cohort / File(s) Summary
Response Layer
pida-core/core-api/src/main/kotlin/com/pida/presentation/v1/flowerspot/response/FlowerSpotAllResponse.kt
Added optional previewUrl: String? field to FlowerSpotResponseDto with Swagger schema annotation. Mapper populates it via flowerSpot.imageUrls.firstOrNull().
Facade Layer
pida-core/core-domain/src/main/kotlin/com/pida/flowerspot/FlowerSpotFacade.kt
Updated readFlowerSpotDetails() and findAllFlowerSpot() to fetch and populate imageUrls in FlowerSpotDetails construction via imageS3Caller.getImageUrl() with FLOWERSPOT prefix.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant FlowerSpotFacade
    participant ImageS3Caller
    participant S3
    participant ResponseMapper
    
    Client->>FlowerSpotFacade: query flower spot(s)
    FlowerSpotFacade->>ImageS3Caller: getImageUrl(FLOWERSPOT, spotId)
    ImageS3Caller->>S3: fetch image URLs
    S3-->>ImageS3Caller: image URLs
    ImageS3Caller-->>FlowerSpotFacade: List<String>
    FlowerSpotFacade->>FlowerSpotFacade: populate imageUrls in FlowerSpotDetails
    FlowerSpotFacade-->>ResponseMapper: FlowerSpotDetails with imageUrls
    ResponseMapper->>ResponseMapper: extract previewUrl = imageUrls.firstOrNull()
    ResponseMapper-->>Client: FlowerSpotResponseDto with previewUrl
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • char-yb

Poem

🐰 A flower spot needs clothes so fine,
With images to help them shine,
From S3 clouds we fetch them quick,
Preview first—that's our trick!
Cherry blossoms now in view! 🌸

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed The PR implements the objective from issue #80 by adding image URLs to the /flowerspot API response with a preview URL field in the response DTO.
Out of Scope Changes check ✅ Passed All changes are directly related to the stated objective: adding preview image URLs to the flower spot API response with no unrelated modifications.
Title check ✅ Passed The PR title accurately describes the main change: adding preview image URLs to the flowerspot place list response, which is the core objective implemented across both files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeeHanEum LeeHanEum changed the title [Feature] [Feature] Add preview image URLs to place list response Jan 17, 2026
@LeeHanEum LeeHanEum changed the title [Feature] Add preview image URLs to place list response [Feature] Add preview image URLs to flowerspot response Jan 17, 2026
@LeeHanEum LeeHanEum changed the title [Feature] Add preview image URLs to flowerspot response [Feature] Add preview image URLs to flowerspot place list response Jan 17, 2026
Copy link
Copy Markdown
Member

@char-yb char-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first 확인!
LGTM

@LeeHanEum LeeHanEum merged commit ba0059e into develop Jan 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ 벚꽃 장소 조회 API 이미지 URL 제공

2 participants