[Feature] Add preview image URLs to flowerspot place list response#81
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe changes extend the flower spot API to include image URLs. The facade layer fetches image URLs from S3 for both single-spot and bulk queries, while the response layer adds a preview URL field representing the first image in the set. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant FlowerSpotFacade
participant ImageS3Caller
participant S3
participant ResponseMapper
Client->>FlowerSpotFacade: query flower spot(s)
FlowerSpotFacade->>ImageS3Caller: getImageUrl(FLOWERSPOT, spotId)
ImageS3Caller->>S3: fetch image URLs
S3-->>ImageS3Caller: image URLs
ImageS3Caller-->>FlowerSpotFacade: List<String>
FlowerSpotFacade->>FlowerSpotFacade: populate imageUrls in FlowerSpotDetails
FlowerSpotFacade-->>ResponseMapper: FlowerSpotDetails with imageUrls
ResponseMapper->>ResponseMapper: extract previewUrl = imageUrls.firstOrNull()
ResponseMapper-->>Client: FlowerSpotResponseDto with previewUrl
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이 사항
📝 참고
📌 체크 리스트
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.