Skip to content

Conversation

@s9hn
Copy link
Member

@s9hn s9hn commented Apr 26, 2025

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

드디어 멀티 모듈 환경이 구축되었습니다~

  1. 코어 모듈 생성
  1. 빌드로직 모듈 생성

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

길고길고 긴 작업이 끝났군용
해당 피알의 세부 작업 내용은 위 링크를 통해 확인 가능합니다.
다행히 다음 사일로부턴 멀티모듈 환경에서 작업할 수 있겠군요 ㅎㅎ

s9hn and others added 30 commits March 20, 2025 17:06
refactor: 프로젝트 Modularization 적용 (1)
@github-actions github-actions bot requested review from junseo511, m6z1 and yeonjeen April 26, 2025 11:14
@s9hn s9hn changed the title Feat/612 refactor: 프로젝트 Modularization 적용 Apr 26, 2025
@s9hn s9hn added 🍯 [FEAT] 새로운 기능을 개발합니다. ♻️ [REFACTOR] 기존 코드를 리팩토링합니다. ⚖️ 재상 세훈 전지적 세훈 시점 🚧 [BUILD] 빌드 업무 수정, 패키지 매니저 수정합니다. labels Apr 26, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseDialogFragment<DialogReportPopupMenuBinding>(dialog_report_popup_menu) {


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseDialogFragment<DialogReportDonePopupMenuBinding>(dialog_report_done_popup_menu) {


🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline before annotation


🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline after last annotation


🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'

val likeCount: Int = view.findViewById<TextView>(tv_my_activity_thumb_up_count)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 16)


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseBottomSheetDialog<DialogNovelRatingDateBinding>(dialog_novel_rating_date) {


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseBottomSheetDialog<DialogNovelRatingKeywordBinding>(dialog_novel_rating_keyword) {


🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Unexpected newline before '.'

.also { websosoChip -> binding.wcgNovelRatingKeywordSearchResult.addChip(websosoChip) }


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression

private fun updatedCategories(keyword: KeywordModel): List<CategoriesModel.CategoryModel> {


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseFragment<FragmentOnboardingSecondBinding>(fragment_onboarding_second) {


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString(


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString(


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString(


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString(


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString(


🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon

MYSTERY("미스터리", "mystery", ic_onboarding_mystery);


🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ";"

MYSTERY("미스터리", "mystery", ic_onboarding_mystery);


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseFragment<FragmentOtherUserLibraryBinding>(fragment_other_user_library) {


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseActivity<ActivityProfileDisclosureBinding>(activity_profile_disclosure) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseDialogFragment<DialogMinimumVersionPopupMenuBinding>(dialog_minimum_version_popup_menu) {


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseBottomSheetDialog<DialogTermsAgreementBinding>(dialog_terms_agreement) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature


🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseActivity<ActivityWithdrawSecondBinding>(activity_withdraw_second) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'buildConfigExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'manifestExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'projectExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'websosoDependenciesExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression

private fun safeFindLibrary(alias: String): Provider<MinimalExternalModuleDependency> {


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression

private fun safeFindBundle(alias: String): Provider<ExternalModuleDependencyBundle> {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

private fun addDependency(configuration: String, dependency: Any) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

private fun addDependency(configuration: String, dependency: Any) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

private fun addDependency(configuration: String, dependency: Any) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

private fun handleStringDependency(alias: String, configuration: String) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

private fun handleStringDependency(alias: String, configuration: String) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

private fun handleStringDependency(alias: String, configuration: String) {


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "kapt")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "kapt")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "implementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "implementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "androidTestImplementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "androidTestImplementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

else addDependency("androidTestImplementation", alias)


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

else addDependency("androidTestImplementation", alias)


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "debugImplementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "debugImplementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "testImplementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "testImplementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File 'Type.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'WebsosoTypography.kt'


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list

Copy link
Member

@m6z1 m6z1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

노가다 작업 넘 고생하셨어요
이륙허가🚀

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

ktlint

🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type

BaseActivity<ActivityWithdrawSecondBinding>(activity_withdraw_second) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'buildConfigExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature

fun getLocalProperty(rootDir: File, key: String): String =


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'manifestExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'projectExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'websosoDependenciesExtensions.kt' should conform PascalCase


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression

private fun safeFindLibrary(alias: String): Provider<MinimalExternalModuleDependency> {


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression

private fun safeFindBundle(alias: String): Provider<ExternalModuleDependencyBundle> {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

private fun addDependency(configuration: String, dependency: Any) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

private fun addDependency(configuration: String, dependency: Any) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

private fun addDependency(configuration: String, dependency: Any) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis

private fun handleStringDependency(alias: String, configuration: String) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline

private fun handleStringDependency(alias: String, configuration: String) {


🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis

private fun handleStringDependency(alias: String, configuration: String) {


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression


🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "kapt")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "kapt")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "implementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "implementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "androidTestImplementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "androidTestImplementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

else addDependency("androidTestImplementation", alias)


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

else addDependency("androidTestImplementation", alias)


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "debugImplementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "debugImplementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline

if (alias is String) handleStringDependency(alias, "testImplementation")


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }

if (alias is String) handleStringDependency(alias, "testImplementation")


🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline


🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }


🚫 [ktlint] standard:filename reported by reviewdog 🐶
File 'Type.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'WebsosoTypography.kt'


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list


🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list

val isNovelCompleted: LiveData<Boolean?> get() = _isNovelCompleted

private val _selectedSeriesStatus: MutableLiveData<SeriesStatus?> = MutableLiveData()
private val _selectedSeriesStatus: MutableLiveData<SeriesStatus?> = MutableLiveData()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [ktlint] standard:backing-property-naming reported by reviewdog 🐶
Backing property is only allowed when a matching property or function exists

@s9hn s9hn merged commit 96584ea into develop Apr 28, 2025
@m6z1 m6z1 deleted the feat/612 branch April 30, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚖️ 재상 세훈 전지적 세훈 시점 🚧 [BUILD] 빌드 업무 수정, 패키지 매니저 수정합니다. 🍯 [FEAT] 새로운 기능을 개발합니다. ♻️ [REFACTOR] 기존 코드를 리팩토링합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: 프로젝트 Modularization 적용

4 participants