-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: 프로젝트 Modularization 적용 #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
refactor: 프로젝트 Modularization 적용 (1)
refactor: 프로젝트 Modularization 적용 (3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/main/feed/dialog/FeedReportDialogFragment.kt
Line 24 in e0a3ed4
| BaseDialogFragment<DialogReportPopupMenuBinding>(dialog_report_popup_menu) { |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/main/feed/dialog/FeedReportDoneDialogFragment.kt
Line 16 in e0a3ed4
| BaseDialogFragment<DialogReportDonePopupMenuBinding>(dialog_report_done_popup_menu) { |
🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline before annotation
| class HomeViewModel @Inject constructor( |
🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline after last annotation
| class HomeViewModel @Inject constructor( |
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
WSS-Android/app/src/main/java/com/into/websoso/ui/main/myPage/myActivity/MyActivityFragment.kt
Line 180 in e0a3ed4
| val likeCount: Int = view.findViewById<TextView>(tv_my_activity_thumb_up_count) |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (12) (should be 16)
Line 53 in e0a3ed4
| WebsosoTheme.typography.body2, |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingDateBottomSheetDialog.kt
Line 20 in e0a3ed4
| BaseBottomSheetDialog<DialogNovelRatingDateBinding>(dialog_novel_rating_date) { |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
Line 37 in e0a3ed4
| BaseBottomSheetDialog<DialogNovelRatingKeywordBinding>(dialog_novel_rating_keyword) { |
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Unexpected newline before '.'
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
Line 220 in e0a3ed4
| .also { websosoChip -> binding.wcgNovelRatingKeywordSearchResult.addChip(websosoChip) } |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
Line 284 in e0a3ed4
| keyCode == KeyEvent.KEYCODE_BACK && |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
Line 285 in e0a3ed4
| event.action == KeyEvent.ACTION_UP -> { |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
Line 291 in e0a3ed4
| keyCode == KeyEvent.KEYCODE_BACK && |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (24) (should be 20)
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/NovelRatingKeywordBottomSheetDialog.kt
Line 292 in e0a3ed4
| event.action == KeyEvent.ACTION_UP -> { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/app/src/main/java/com/into/websoso/ui/novelRating/model/NovelRatingUiModel.kt
Line 98 in e0a3ed4
| private fun updatedCategories(keyword: KeywordModel): List<CategoriesModel.CategoryModel> { |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/second/OnboardingSecondFragment.kt
Line 20 in e0a3ed4
| BaseFragment<FragmentOnboardingSecondBinding>(fragment_onboarding_second) { |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/second/OnboardingSecondFragment.kt
Line 42 in e0a3ed4
| if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString( |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/second/OnboardingSecondFragment.kt
Line 42 in e0a3ed4
| if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString( |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/second/OnboardingSecondFragment.kt
Line 42 in e0a3ed4
| if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString( |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/second/OnboardingSecondFragment.kt
Line 42 in e0a3ed4
| if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString( |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/second/OnboardingSecondFragment.kt
Line 42 in e0a3ed4
| if (userModelInfo.birthYear != 0) userModelInfo.birthYear.toString() else getString( |
🚫 [ktlint] standard:no-semi reported by reviewdog 🐶
Unnecessary semicolon
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/third/model/Genre.kt
Line 22 in e0a3ed4
| MYSTERY("미스터리", "mystery", ic_onboarding_mystery); |
🚫 [ktlint] standard:trailing-comma-on-declaration-site reported by reviewdog 🐶
Missing trailing comma before ";"
WSS-Android/app/src/main/java/com/into/websoso/ui/onboarding/third/model/Genre.kt
Line 22 in e0a3ed4
| MYSTERY("미스터리", "mystery", ic_onboarding_mystery); |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
Line 35 in e0a3ed4
| BaseFragment<FragmentOtherUserLibraryBinding>(fragment_other_user_library) { |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/profileDisclosure/ProfileDisclosureActivity.kt
Line 18 in e0a3ed4
| BaseActivity<ActivityProfileDisclosureBinding>(activity_profile_disclosure) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature
WSS-Android/app/src/main/java/com/into/websoso/ui/profileDisclosure/ProfileDisclosureActivity.kt
Line 60 in e0a3ed4
| fun getIntent(context: Context): Intent = |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)
WSS-Android/app/src/main/java/com/into/websoso/ui/profileEdit/ProfileEditActivity.kt
Line 288 in e0a3ed4
| source.toString().substring(start, end) + |
🚫 [ktlint] standard:indent reported by reviewdog 🐶
Unexpected indentation (28) (should be 24)
WSS-Android/app/src/main/java/com/into/websoso/ui/profileEdit/ProfileEditActivity.kt
Line 289 in e0a3ed4
| dest.toString().substring(dend) |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/splash/dialog/MinimumVersionDialogFragment.kt
Line 13 in e0a3ed4
| BaseDialogFragment<DialogMinimumVersionPopupMenuBinding>(dialog_minimum_version_popup_menu) { |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/termsAgreement/TermsAgreementDialogBottomSheet.kt
Line 29 in e0a3ed4
| BaseBottomSheetDialog<DialogTermsAgreementBinding>(dialog_terms_agreement) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature
WSS-Android/app/src/main/java/com/into/websoso/ui/termsAgreement/TermsAgreementDialogBottomSheet.kt
Line 133 in e0a3ed4
| private fun getToggleIcon(isChecked: Boolean): Int = |
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/withdraw/second/WithdrawSecondActivity.kt
Line 24 in e0a3ed4
| BaseActivity<ActivityWithdrawSecondBinding>(activity_withdraw_second) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature
WSS-Android/app/src/main/java/com/into/websoso/ui/withdraw/second/WithdrawSecondActivity.kt
Line 167 in e0a3ed4
| fun getIntent(context: Context): Intent = |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'buildConfigExtensions.kt' should conform PascalCase
| package com.into.websoso |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in e0a3ed4
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in e0a3ed4
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in e0a3ed4
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in e0a3ed4
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 34 in e0a3ed4
| fun string(name: String, key: String) |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 34 in e0a3ed4
| fun string(name: String, key: String) |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 34 in e0a3ed4
| fun string(name: String, key: String) |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'manifestExtensions.kt' should conform PascalCase
| package com.into.websoso |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'projectExtensions.kt' should conform PascalCase
| package com.into.websoso |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'websosoDependenciesExtensions.kt' should conform PascalCase
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 1 in e0a3ed4
| package com.into.websoso |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 30 in e0a3ed4
| private fun safeFindLibrary(alias: String): Provider<MinimalExternalModuleDependency> { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 35 in e0a3ed4
| private fun safeFindBundle(alias: String): Provider<ExternalModuleDependencyBundle> { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 40 in e0a3ed4
| private fun addDependency(configuration: String, dependency: Any) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 40 in e0a3ed4
| private fun addDependency(configuration: String, dependency: Any) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 40 in e0a3ed4
| private fun addDependency(configuration: String, dependency: Any) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 44 in e0a3ed4
| private fun handleStringDependency(alias: String, configuration: String) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 44 in e0a3ed4
| private fun handleStringDependency(alias: String, configuration: String) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 44 in e0a3ed4
| private fun handleStringDependency(alias: String, configuration: String) { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 49 in e0a3ed4
| private fun isBundle(alias: String): Boolean { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 58 in e0a3ed4
| fun project(path: String): ProjectDependency { |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 63 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "kapt") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 63 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "kapt") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 64 in e0a3ed4
| else addDependency("kapt", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 64 in e0a3ed4
| else addDependency("kapt", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 68 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "implementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 68 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "implementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 69 in e0a3ed4
| else addDependency("implementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 69 in e0a3ed4
| else addDependency("implementation", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 73 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "androidTestImplementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 73 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "androidTestImplementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 74 in e0a3ed4
| else addDependency("androidTestImplementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 74 in e0a3ed4
| else addDependency("androidTestImplementation", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 78 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "debugImplementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 78 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "debugImplementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 79 in e0a3ed4
| else addDependency("debugImplementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 79 in e0a3ed4
| else addDependency("debugImplementation", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 83 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "testImplementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 83 in e0a3ed4
| if (alias is String) handleStringDependency(alias, "testImplementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 84 in e0a3ed4
| else addDependency("testImplementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 84 in e0a3ed4
| else addDependency("testImplementation", alias) |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File 'Type.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'WebsosoTypography.kt'
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 1 in e0a3ed4
| package com.into.websoso.core.designsystem.theme |
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 21 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 25 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 31 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 34 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 52 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 56 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 62 in e0a3ed4
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
m6z1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
노가다 작업 넘 고생하셨어요
이륙허가🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
ktlint
🚫 [ktlint] standard:class-signature reported by reviewdog 🐶
Expected single space before the super type
WSS-Android/app/src/main/java/com/into/websoso/ui/withdraw/second/WithdrawSecondActivity.kt
Line 24 in 8cfc362
| BaseActivity<ActivityWithdrawSecondBinding>(activity_withdraw_second) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature
WSS-Android/app/src/main/java/com/into/websoso/ui/withdraw/second/WithdrawSecondActivity.kt
Line 167 in 8cfc362
| fun getIntent(context: Context): Intent = |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'buildConfigExtensions.kt' should conform PascalCase
| package com.into.websoso |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in 8cfc362
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in 8cfc362
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in 8cfc362
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
First line of body expression fits on same line as function signature
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 30 in 8cfc362
| fun getLocalProperty(rootDir: File, key: String): String = |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 34 in 8cfc362
| fun string(name: String, key: String) |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 34 in 8cfc362
| fun string(name: String, key: String) |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/buildConfigExtensions.kt
Line 34 in 8cfc362
| fun string(name: String, key: String) |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'manifestExtensions.kt' should conform PascalCase
| package com.into.websoso |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between opening parenthesis and first parameter name
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
No whitespace expected between last parameter and closing parenthesis
| block: ManifestScope.() -> Unit, |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'projectExtensions.kt' should conform PascalCase
| package com.into.websoso |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File name 'websosoDependenciesExtensions.kt' should conform PascalCase
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 1 in 8cfc362
| package com.into.websoso |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 30 in 8cfc362
| private fun safeFindLibrary(alias: String): Provider<MinimalExternalModuleDependency> { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 35 in 8cfc362
| private fun safeFindBundle(alias: String): Provider<ExternalModuleDependencyBundle> { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 40 in 8cfc362
| private fun addDependency(configuration: String, dependency: Any) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 40 in 8cfc362
| private fun addDependency(configuration: String, dependency: Any) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 40 in 8cfc362
| private fun addDependency(configuration: String, dependency: Any) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected after opening parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 44 in 8cfc362
| private fun handleStringDependency(alias: String, configuration: String) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Parameter should start on a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 44 in 8cfc362
| private fun handleStringDependency(alias: String, configuration: String) { |
🚫 [ktlint] standard:function-signature reported by reviewdog 🐶
Newline expected before closing parenthesis
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 44 in 8cfc362
| private fun handleStringDependency(alias: String, configuration: String) { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 49 in 8cfc362
| private fun isBundle(alias: String): Boolean { |
🚫 [ktlint] standard:function-expression-body reported by reviewdog 🐶
Function body should be replaced with body expression
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 58 in 8cfc362
| fun project(path: String): ProjectDependency { |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 63 in 8cfc362
| if (alias is String) handleStringDependency(alias, "kapt") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 63 in 8cfc362
| if (alias is String) handleStringDependency(alias, "kapt") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 64 in 8cfc362
| else addDependency("kapt", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 64 in 8cfc362
| else addDependency("kapt", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 68 in 8cfc362
| if (alias is String) handleStringDependency(alias, "implementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 68 in 8cfc362
| if (alias is String) handleStringDependency(alias, "implementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 69 in 8cfc362
| else addDependency("implementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 69 in 8cfc362
| else addDependency("implementation", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 73 in 8cfc362
| if (alias is String) handleStringDependency(alias, "androidTestImplementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 73 in 8cfc362
| if (alias is String) handleStringDependency(alias, "androidTestImplementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 74 in 8cfc362
| else addDependency("androidTestImplementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 74 in 8cfc362
| else addDependency("androidTestImplementation", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 78 in 8cfc362
| if (alias is String) handleStringDependency(alias, "debugImplementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 78 in 8cfc362
| if (alias is String) handleStringDependency(alias, "debugImplementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 79 in 8cfc362
| else addDependency("debugImplementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 79 in 8cfc362
| else addDependency("debugImplementation", alias) |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 83 in 8cfc362
| if (alias is String) handleStringDependency(alias, "testImplementation") |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 83 in 8cfc362
| if (alias is String) handleStringDependency(alias, "testImplementation") |
🚫 [ktlint] standard:if-else-wrapping reported by reviewdog 🐶
Expected a newline
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 84 in 8cfc362
| else addDependency("testImplementation", alias) |
🚫 [ktlint] standard:multiline-if-else reported by reviewdog 🐶
Missing { ... }
WSS-Android/build-logic/src/main/kotlin/com/into/websoso/websosoDependenciesExtensions.kt
Line 84 in 8cfc362
| else addDependency("testImplementation", alias) |
🚫 [ktlint] standard:filename reported by reviewdog 🐶
File 'Type.kt' contains a single class and possibly also extension functions for that class and should be named same after that class 'WebsosoTypography.kt'
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 1 in 8cfc362
| package com.into.websoso.core.designsystem.theme |
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 21 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 25 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 31 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value parameter list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 34 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 52 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 56 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
WSS-Android/core/designsystem/src/main/java/com/into/websoso/core/designsystem/theme/Type.kt
Line 62 in 8cfc362
🚫 [ktlint] standard:no-blank-line-in-list reported by reviewdog 🐶
Unexpected blank line(s) in value argument list
| val isNovelCompleted: LiveData<Boolean?> get() = _isNovelCompleted | ||
|
|
||
| private val _selectedSeriesStatus: MutableLiveData<SeriesStatus?> = MutableLiveData() | ||
| private val _selectedSeriesStatus: MutableLiveData<SeriesStatus?> = MutableLiveData() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [ktlint] standard:backing-property-naming reported by reviewdog 🐶
Backing property is only allowed when a matching property or function exists
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
드디어 멀티 모듈 환경이 구축되었습니다~
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
길고길고 긴 작업이 끝났군용
해당 피알의 세부 작업 내용은 위 링크를 통해 확인 가능합니다.
다행히 다음 사일로부턴 멀티모듈 환경에서 작업할 수 있겠군요 ㅎㅎ