feat: Datastore 모듈 구현 #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s9hn
added
🍯 [FEAT]
m6z1
approved these changes
May 7, 2025
| override suspend fun postLogin( | ||
| platform: AuthPlatform, | ||
| authToken: AuthToken, | ||
| ) = when (platform) { |
Comment on lines
16
to
21
| fun toData(): AccountEntity = | ||
| AccountEntity( | ||
| authorization = authorization, | ||
| refreshToken = refreshToken, | ||
| isRegister = isRegister, | ||
| ) |
Member
There was a problem hiding this comment.
a: 기존에는 mapper 를 따로 파일 분리했는데 dto 에서 매퍼를 만드신 이유가 있나욥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
공식문서의 권장에 따라 SharedPreference를 제거하고, 비동기적이며 일관된 트랜잭션이 가능한 Datastore로 마이그레이션 합니다.
간단히 키-쌍 값을 사용해 토큰을 관리하므로, Preferences Datastore 방식을 사용합니다.
유저 정보를 관리하는 Datastore를 추가할 경우, Proto Datastore를 사용하면 좋을 것 같습니다.
Datastore는 별도의 보안 로직이 없으므로, 추후 보안 모듈도 추가 구현 예정입니다.