-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 서재UI/UX 개편 (7) - API 마이그레이션 및 기존 코드 제거 #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
m6z1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paging 도 버전 카탈로그 적용 부탁드립니다!
| implementation(libs.firebase.analytics) | ||
| implementation(libs.firebase.messaging) | ||
|
|
||
| implementation("androidx.paging:paging-runtime:3.3.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r: 얘도 버전 카탈로그 이용해서 관리부탁드립니다
| } | ||
|
|
||
| dependencies { | ||
| implementation("androidx.paging:paging-runtime:3.3.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r: 여기두
|
|
||
| dependencies { | ||
| implementation(projects.data.library) | ||
| implementation("androidx.paging:paging-runtime:3.3.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r: 33
| implementation(projects.data.library) | ||
| implementation(projects.domain.library) | ||
|
|
||
| implementation("androidx.paging:paging-runtime:3.3.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r: 44
yeonjeen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!!
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
현재는 간단한 로컬 페이징만 구현되어 있습니다.
다음 이슈인 리모트-페이징 구현을 위해 임시로 LocalDataSource쪽을 주석처리 해놓았습니다.
룸 캐싱은 추후 이슈에서 다룰 예정입니다.