feat: targetSdk35 로 수정 #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughAndroid 프로젝트의 빌드 설정에서 targetSdk 버전이 35로 추가 및 수정되었습니다. Changes
Sequence Diagram(s)(생성할 시퀀스 다이어그램이 없습니다.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(Out-of-scope 변경사항이 없습니다.) Suggested reviewers
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/build.gradle.kts(1 hunks)build-logic/src/main/kotlin/websoso.android.kotlin.gradle.kts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
app/build.gradle.kts (1)
26-27: targetSdk 35 중복 선언 없음 확인
- app/build.gradle.kts (26줄)에만
targetSdk = 35선언- 다른 모듈/파일에 중복 선언이 발견되지 않았습니다
targetSdk 상향에 따른 런타임·행동 변화(포그라운드 서비스 타입, 권한 플래그, 알림/백그라운드 제한 등)가 있을 수 있으므로, Android Lint 검사 및 QA 점검을 권장드립니다.
|
|
||
| androidExtension.apply { | ||
| compileSdk = 34 | ||
| compileSdk = 35 |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
compileSdk 35 적용 LGTM — 툴체인/CI 호환성만 확인 부탁
설정 자체는 문제 없습니다. Kotlin/JVM 17 설정과도 일치합니다. CI 환경에 Android SDK 35(Platform/Build-Tools)가 설치되어 있는지, 그리고 사용 중인 AGP 버전이 SDK 35를 공식 지원하는지 확인해 주세요.
아래 스크립트로 레포 전체에서 compileSdk/targetSdk 사용 현황과 AGP/플러그인 버전을 점검할 수 있습니다.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== compileSdk / targetSdk 선언 위치 점검 =="
rg -n --hidden -S $'compileSdk\\s*=\\s*' || true
rg -n --hidden -S $'targetSdk\\s*=\\s*' || true
echo
echo "== Android Gradle Plugin/플러그인 버전 단서 검색 =="
rg -n --hidden -S 'com.android.tools.build:gradle' || true
rg -n --hidden -S 'id\\(\"com.android.application\"\\)|id\\(\"com.android.library\"\\)' -A 2 || true
fd -H libs.versions.toml | xargs -I{} sh -c 'echo "---- {} ----"; cat "{}"'
echo
echo "== Gradle 플러그인 버전 카탈로그 내 android/AGP 관련 키워드 점검 =="
rg -n --hidden -S 'agp|androidGradlePlugin|com.android' --glob 'libs.versions.toml' || trueLength of output: 9566
컴파일 SDK 35 통일 및 CI 환경 확인 요청
- core/resource 모듈(
core/resource/build.gradle.kts:7)이 여전히compileSdk = 34로 설정되어 있습니다.35로 업데이트해주세요. - app 모듈에서는 이미
targetSdk = 35로 설정되어 있습니다. gradle/libs.versions.toml에서 Android Gradle Plugin 버전은8.1.3으로 확인되며, AGP 8.1.3은 compileSdk 35를 공식 지원합니다.- CI 환경에 Android SDK 35(Platform/Build-Tools)가 설치되어 있는지 검증 부탁드립니다.
🤖 Prompt for AI Agents
In build-logic/src/main/kotlin/websoso.android.kotlin.gradle.kts at line 11,
update the compileSdk version from 34 to 35 to unify the compile SDK version
across modules. Also, check the core/resource module's build.gradle.kts file at
line 7 and update its compileSdk to 35. Verify that the CI environment has
Android SDK 35 platform and build-tools installed to support this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
-> build-logic 의
websoso.android.kotlin.gradle.kts에 추가하지 않은 이유는compileSdk는 CommonExtension에 공통 속성이라 바로 쓸 수 있지만,targetSdk는 앱 전용 ApplicationExtension에만 있어 CommonExtension에서는 접근할 수 없기 때문입니다.-> 분기처리 하는 함수 써서 할 수는 있지만,
websoso.android.kotlin.gradle.kts요 파일은 모두 사용되는 것이고 굳이 사용처가 아닌 곳에서 알 필요가 없다고 판단에 사용하는 곳인 app의build.gradle.kts에만 추가했습니다.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
N/A
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit