[Refactor] #125 - DeletePopup MVVM 패턴 적용 #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guryss
approved these changes
Feb 25, 2024
Comment on lines
33
to
34
| let deleteButtonDidTapEvent: Observable<Void> | ||
|
|
Naknakk
approved these changes
Feb 27, 2024
Contributor
Naknakk
left a comment
Naknakk
left a comment
There was a problem hiding this comment.
고생했습니다!-! 이전 코리 내용 같이 고려해보면 될 것 같아요!! 팝업이라 이전 뷰 내용 가져오기도 애매하구 뷰모델이 많아질 수 밖에 없어서 아쉬우네요 .,. 애매했을텐데 고생했습니당!-!
ena-isme
approved these changes
Feb 27, 2024
| .flatMapLatest { | ||
| self.deleteUserNovel() | ||
| } | ||
| .subscribe(with: self, onNext: { owner, _ in |
Member
There was a problem hiding this comment.
W3
self 사용하는 부분이 없어서 owner 로 작성안해도 될 것 같기는 해요~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️Issue
#125
🌟Motivation
DeletePopupViewController에 MVVM 패턴을 적용했습니다.
🌟Key Changes
🌟Simulation
없어용가리
🌟To Reviewer
popupStatus도 viewModel이 들고 있는게 맞다는 생각이 들지만,, 뷰컨에서 rootView 초기화시 popupStatus가 필요해 일단 뷰컨에서 들고 있도록 구현했쌉다 🤓