[Design #137(2) - FeedView UI 구현 #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naknakk
reviewed
Jun 5, 2024
| guard let windowScene = (scene as? UIWindowScene) else { return } | ||
|
|
||
| let navigationController = UINavigationController(rootViewController: WSSTabBarController()) | ||
| let navigationController = UINavigationController(rootViewController: FeedViewController()) |
Comment on lines
149
to
163
| private func novelTitleAttribute(of label: UILabel) { | ||
| label.do { | ||
| $0.makeAttribute(with: label.text)? | ||
| .lineSpacing(spacingPercentage: 140) | ||
| .kerning(kerningPixel: -1.2) | ||
| .applyAttribute() | ||
| $0.font = .HeadLine1 | ||
| $0.textColor = .White | ||
| $0.textAlignment = .center | ||
| $0.lineBreakMode = .byTruncatingTail | ||
| $0.lineBreakStrategy = .hangulWordPriority | ||
| $0.numberOfLines = 3 | ||
| } | ||
| } | ||
| */ |
Comment on lines
+245
to
+256
|
|
||
| func lineHeightMultiple(_ multiple: CGFloat) -> TextAttributeSet { | ||
| let style = NSMutableParagraphStyle() | ||
| style.lineHeightMultiple = multiple | ||
| self.attributedString.addAttribute( | ||
| .paragraphStyle, | ||
| value: style, | ||
| range: NSRange(location: 0, length: attributedString.length) | ||
| ) | ||
|
|
||
| return self | ||
| } |
Contributor
There was a problem hiding this comment.
W3
요걸 반영해서 font 적용을 위한 UILabel+의 메서드도 곧 수정해서 다시 PR 올리겠삼 . .
Comment on lines
+77
to
+78
| let dummyFeedImage = "https://d2ur3228349jyd.cloudfront.net/assets/img/common/characters/kuromi.png" | ||
| let dummyFeedData = [TotalFeeds(userId: 123, |
Contributor
There was a problem hiding this comment.
W3
요렇게 전역변수로 선언되어 있는건 나중에 더미 레포지토리 만들면 꼭 수정해주세용~~ 또는 구조체에 static let으로 선언해도 될 듯 !
Contributor
There was a problem hiding this comment.
W1
실행했을 때 좋아요 버튼과 댓글 버튼의 색이 달라서 살펴봤더니, 옜날 좋아요 이미지 같아요!
지금 좋아요 버튼과 댓글 버튼은 둘다 가로세로 20이고, gray200 색으로 되어있어서, 디자인 시스템에서 다시 들고와야 할 것 같아요!
added 2 commits
June 8, 2024 19:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️Issue
close #137
🌟Motivation
FeedView UI 를 구현하였습니다.
네트워크 연결 + ViewModel 를 통한 Action 추가 + 무한스크롤 + UI 부분 수정
추가 구현해야 합니다 !
🌟Simulation
🌟To Reviewer
깃 컨플릿 때문에 재PR 올립니둥 ,, 💖
첫 번째 PR