[Feat] #48 - RegisterNormal 기능 80% 구현 #60

Naknakk · 2024-01-15T17:41:18Z

⭐️Issue

#48

🌟Motivation

RegisterNormal 기능 80% 구현 했습니다.. ( 플랫폼 버튼 누를 때 webView 띄우는 것만 남았습니다. )

🌟Key Changes

읽기 상태에 따른 뷰 변화
DatePicker를 이용해 읽은 기간 설정

🌟Simulation

🌟To Reviewer

코드가 많이 더러운데요 ... 일단 구현하는데 초점을 두느라 이렇게 되었습니다. 코드가 이해되지 않는 부분은 리뷰 달아주시면 빠르게 답변 달겠습니다.
추후 반드시! 더러운 부분은 수정할게요. 일단 서버 붙이러 떠나겠습니다..

🌟Reference

hyowon612

까다로운 부분 많았을텐데 정말 수고 많았어요!!!👼🏻

hyowon612 · 2024-01-16T03:27:59Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+
+    // MARK: - UI Components
+
+    private let background = UIView()


W3
네이밍 통일해주세용 (backgroundView)

hyowon612 · 2024-01-16T03:28:36Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+        setUI()
+        setHieararchy()
+        setLayout()
+        selectedButton = startButton


W2
요건 무슨 코드인가용?

datePicker를 처음 열었을 때 시작 날짜 버튼이 활성화 되어있어야하므로, 이를 위해 추가한 코드입니다!

hyowon612 · 2024-01-16T03:29:32Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+
+

W3
공백 없애주세여

hyowon612 · 2024-01-16T03:30:26Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+        readingStatusLabel.snp.makeConstraints {
+            $0.height.equalTo(42)
+        }
+
+        dropStatusLabel.snp.makeConstraints {
+            $0.height.equalTo(42)
+        }


W2
라벨은 높이 지정 안해줘도 폰트에 맞춰서 저절로 높이 잡히지 않나요?

말로 설명해써요 피그마 보면서 같이 이야기해야 편할 것 같아서!~!
간단하게 적어두면 라벨 고유 높이보다 더 큰 높이가 필요해서 주었습니다!!

hyowon612 · 2024-01-16T03:32:11Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+    private func buttonDateStyle(of label: UILabel) {
+        label.do {
+            $0.makeAttribute(with: $0.text)?
+                .lineSpacing(spacingPercentage: 145)
+                .applyAttribute()
+            $0.font = .Label1
+        }
+    }
+
+    private func buttonTitleStyle(of label: UILabel) {


W2
함수 네이밍 컨벤션 맞춰주세용!

hyowon612 · 2024-01-16T03:35:00Z

...Normal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomToggleButton.swift

-            if self.isOn {
-                self.onStateLayout()
+    func changeState(_ state: Bool) {
+        UIView.animate(withDuration: self.animationDuration) {


W3
애니메이션도 넣었네용 짱 ~

hyowon612 · 2024-01-16T03:35:56Z

...Normal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomToggleButton.swift

+
+        func onStateLayout() {
+            circleView.snp.updateConstraints {
+                $0.trailing.equalTo(barView.snp.trailing).inset(2.76)


W3
이 이쁘지 못한 inset은 디자인이 이렇게 돼있는거죠ㅜ?
정수로 수정하는게 좋을거같네욤

전에 한번 이야기해봤는데 이렇게 의도한 거라고 하셔서 그대로 할 것 같아요 !!

hyowon612 · 2024-01-16T03:38:47Z

...tion/Register/RegisterNormal/RegisterNormalViewController/RegisterNormalViewController.swift

+            }()
+
+            popDatePicker.subscribe(onNext: { popDatePicker in
+                view.customDatePicker.isHidden = !popDatePicker


W3
popDatePicker가 Bool값인가여?

맞습니당 좀더 보기 편하게 showDatePicker로 네이밍 변경할게요!

Guryss

굿굿 진짜 고생했어용 끝이 보이기 시작한드앜!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Guryss · 2024-01-16T04:20:56Z

WSSiOS/WSSiOS/App/SceneDelegate.swift


        self.window = UIWindow(windowScene: windowScene)
-        self.window?.rootViewController = navigationController
+        self.window?.rootViewController = RegisterNormalViewController()
        self.window?.makeKeyAndVisible()


W1;
SceneDelegate 복구시켜놓는거 까먹지 않깅

Guryss · 2024-01-16T04:24:04Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+    let dateFormatter: DateFormatter = {
+        let formatter = DateFormatter()
+        formatter.dateFormat = "yyyy-MM-dd"
+        return formatter
+    }()


W2;
DateForMatter는 생각보다 시간복잡도가 매우 크다는 점 알고 계셨나용?
저도 세미나때 static 키워드를 정리하면서 알게 되었는데, 우리가 해당 속성을 다룬다면
꼭 알아두는게 좋을 것 같아 아티클 가져와봅니당 :)
한번 읽어보시고 추후에 DateForMatter를 어떻게 다뤄볼지 얘기해보아용

https://velog.io/@qwerty3345/Swift-DateFormatter%EB%8A%94-%EB%8B%B9%EC%8B%A0%EC%9D%98-%EC%83%9D%EA%B0%81%EB%B3%B4%EB%8B%A4-%EB%B9%84%EC%8B%B8%EB%8B%A4

대박 첨부해준 글 보니 완전 이해 잘 되네요 ㅋㅋㅋㅋㅋㅋㅋ 추후에 빼두는게 정말 중요하겠네요!!! 좋습니다

Guryss · 2024-01-16T04:25:04Z

...erNormal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomDatePicker.swift

+    private let totalStackView = UIStackView()
+
+    private let buttonStackView = UIStackView()
+
+    private let startButton = UIButton()
+    private let startButtonStackView = UIStackView()
+    private let startTitleLabel = UILabel()
+    private let startDateLabel = UILabel()
+
+    private let endButton = UIButton()
+    private let endButtonStackView = UIStackView()
+    private let endTitleLabel = UILabel()
+    private let endDateLabel = UILabel()


뚠뚠 🎵 stackView 사랑은 오늘도 진행중이라네 🎶

Guryss · 2024-01-16T04:28:44Z

...Normal/RegisterNormalView/RegisterNormalAssistantView/RegisterNormalCustomToggleButton.swift

+    private func bind() {
+
    }



W1;
안사용하는 함수면 지워줘도 될듯합니당

최고최고~

Guryss · 2024-01-16T04:33:37Z

...tion/Register/RegisterNormal/RegisterNormalViewController/RegisterNormalViewController.swift

+            buttonStatusSubject
+                .subscribe(onNext: { status in
+                    view.customDatePicker.bindReadStatus(status: status)
+                })
+                .disposed(by: disposeBag)
+        }


Rx 활용 최고네요 !!!

Naknakk added 8 commits January 15, 2024 01:51

[Feat] #48 - ReadStatus에 따른 날짜 선택 뷰 변화 구현

56177ec

[Feat] #48 - ReadDate Toggle 상태에 따라 하단 DatePickerButton hidden 처리 구현.

61f1e5b

[Feat] #48 - CustomDatePicker UI 구현 (실제 Label과 Binding, 모달 구현 필요)

baaedbb

[Feat] #48 - CustomDatePicker 모달인척.. 애니메이션 없이 팝업으로 뜨는 것 완료.

0c199b9

[Feat] #48 - DatePicker Data binding 진행중

11f5fea

[Fix] #48 - 깃 충돌 해결 및 로컬 main 브랜치 최신화

b3e78b6

[Feat] #48 - DatePicker 구현 완료

9aaab92

[Feat] #48 - DatePicker 상단 뷰 Hidden처리 순서 변경

6aef73a

Naknakk linked an issue Jan 15, 2024 that may be closed by this pull request

[Feat] RegisterNormal 기본적인 기능 구현 #48

Closed

3 tasks

Naknakk requested review from Guryss, ena-isme and hyowon612 January 15, 2024 17:41

Naknakk self-assigned this Jan 15, 2024

Naknakk added nagi reviewPlz labels Jan 15, 2024

hyowon612 reviewed Jan 16, 2024

View reviewed changes

Guryss reviewed Jan 16, 2024

View reviewed changes

Naknakk added 3 commits January 16, 2024 15:27

[Fix] #48 - 코드리뷰 반영

a6e929e

[Fix] #48 - ScenDelegate 수정

ec09d95

[Merge] #48 - RegisterNormal 기능 80% 구현 Merge

552e7ed

Naknakk merged commit f01caf1 into main Jan 16, 2024

Naknakk added veryGoodDeveloper and removed reviewPlz labels Jan 16, 2024

Naknakk deleted the Feat/#48 branch January 17, 2024 09:29

[Feat] #48 - RegisterNormal 기능 80% 구현 #60

[Feat] #48 - RegisterNormal 기능 80% 구현 #60

Uh oh!

Conversation

Naknakk commented Jan 15, 2024

⭐️Issue

🌟Motivation

🌟Key Changes

🌟Simulation

🌟To Reviewer

🌟Reference

Uh oh!

hyowon612 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Naknakk Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Guryss left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Naknakk Jan 16, 2024 •

edited

Loading