Conversation
- 불필요한 wrapperView 제거 - 레이아웃 수치 조정
stackView insert 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⭐️Issue
🌟Motivation
피드 상세 내 StackView Spacing 관련한 레이아웃 문제를 해결했습니다.
🌟Key Changes
조건부 UI 처리 방식 개선
기존
insertArrangedSubview/removeFromSuperview방식을 제거했습니다.isHidden기반으로 조건부 UI 제어하도록 구조를 변경했습니다.StackView Spacing 규칙 재정의
기본 spacing을 30으로 통일하고,
다음 조건에 따라
customSpacing적용하도록 했습니다.첨부 이미지 + 연결 작품이 모두 존재할 경우 → 이미지 뒤 spacing 16
reactView 뒤 spacing은 항상 10 유지
applySpacing()함수로 spacing 로직을 일원화했습니다.customSpacing값이 누적되지 않도록 매 바인딩 시 초기화 로직 추가했습니다.Result
StackView spacing이 의도한 디자인 스펙에 맞게 안정적으로 동작하도록 했습니다.
제약 충돌 및 spacing 비정상적으로 축소되는 현상 해결했습니다.
🌟Simulation
🌟To Reviewer
🌟Reference