[Add] 디자인 시스템을 반영한 색상 추가 #163
Conversation
WalkthroughThis pull request introduces multiple new JSON files to the iOS asset catalog. These files, placed in various directories under Changes
Assessment against linked issues
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Wable-iOS/Resource/Color.xcassets/Team/bro10.colorset/Contents.json (1)
1-21: Ensure JSON Validity & Consistency
The JSON structure for the "bro10" color set is correctly defined with its color components and metadata. Please verify that the hexadecimal values (e.g.,"0xFA","0xEB") accurately reflect the intended design system colors. Additionally, it appears there is an extraneous line ("21") following the closing brace—please confirm this is not unintentional and remove it if necessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (23)
Wable-iOS/Resource/Color.xcassets/GrayScale/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Primary/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Secondary/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Secondary/blue10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Secondary/blue50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/System/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/bro10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/bro50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/dk10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/dk50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/drx10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/drx50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/gen10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/gen50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/hle10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/hle50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/kt10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/kt50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/ns10.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/ns50.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/t110.colorset/Contents.json(1 hunks)Wable-iOS/Resource/Color.xcassets/Team/t150.colorset/Contents.json(1 hunks)
🔇 Additional comments (22)
Wable-iOS/Resource/Color.xcassets/Primary/Contents.json (1)
1-7: Valid Metadata for Primary Colors
The metadata file is concise and follows the standard structure with an"info"object containing"author"and"version". This is consistent with the design system requirements and similar asset catalog files.Wable-iOS/Resource/Color.xcassets/System/Contents.json (1)
1-7: Proper Metadata for System Colors
This JSON file provides the necessary asset catalog metadata with the correct"info"properties. It aligns well with the other asset catalog files in the project.Wable-iOS/Resource/Color.xcassets/Secondary/Contents.json (1)
1-7: Consistent Metadata for Secondary Colors
The file maintains consistency by defining the"info"object with"author": "xcode"and"version": 1. This structure is in line with other similar metadata files added to the project.Wable-iOS/Resource/Color.xcassets/GrayScale/Contents.json (1)
1-7: Accurate GrayScale Asset Metadata
The JSON structure here is correctly formatted, containing the required"info"object. Consistency across all asset catalog metadata files is evident, which supports maintainability with the design system updates.Wable-iOS/Resource/Color.xcassets/Team/Contents.json (1)
1-6: JSON Metadata File is correctly structured.The file uses the standard asset catalog metadata format with an "info" object containing the "author" and "version" keys. It meets the design system specifications.
Wable-iOS/Resource/Color.xcassets/Team/ns50.colorset/Contents.json (1)
1-21: Valid Color Set Definition for ns50.The color set is well-defined with the proper "colors" array, color-space declaration, color components (using hex strings), and a universal idiom. The metadata section is also appropriately structured.
Wable-iOS/Resource/Color.xcassets/Team/dk10.colorset/Contents.json (1)
1-21: Proper Color Set Format for dk10.The file correctly defines the color components (with expected hex values and full opacity) and includes the necessary "info" metadata. This adheres to the expected asset catalog conventions.
Wable-iOS/Resource/Color.xcassets/Team/kt50.colorset/Contents.json (1)
1-21: Consistent and Accurate Color Set Definition for kt50.The JSON clearly specifies the sRGB color with its components and sets the idiom to "universal". The metadata is correctly added, ensuring consistency with other asset catalog files.
Wable-iOS/Resource/Color.xcassets/Team/bro50.colorset/Contents.json (1)
1-21: Clear and Correct Definition for bro50 Color Set.This file defines the color set in line with the design system format. All color components are provided using the expected hexadecimal notation, and the metadata is complete.
Wable-iOS/Resource/Color.xcassets/Team/drx10.colorset/Contents.json (1)
1-20: Approved: drx10 color set JSON structure adheres to the design system.
The JSON structure is well-formed with the correct sRGB color components (red:0xE4, green:0xE3, blue:0xF3) and appropriate metadata. This file is consistent with Xcode’s asset catalog format.Wable-iOS/Resource/Color.xcassets/Secondary/blue10.colorset/Contents.json (1)
1-20: Approved: blue10 color set JSON is correctly configured.
The file defines the expected color components (red:0xEF, green:0xF5, blue:0xFD) and includes the standard metadata. It aligns perfectly with the design system requirements.Wable-iOS/Resource/Color.xcassets/Team/gen50.colorset/Contents.json (1)
1-20: Approved: gen50 color set JSON is correctly structured.
The asset shows the proper sRGB specification with matching component values (red:0xAA, green:0x8B, blue:0x30) and metadata. It maintains the consistency observed across the new color files.Wable-iOS/Resource/Color.xcassets/Team/kt10.colorset/Contents.json (1)
1-20: Approved: kt10 color set JSON displays the expected sRGB components and metadata.
The file correctly specifies red (0xFC), green (0xE4), and blue (0xE4) with full opacity via the alpha component. It meets the design system’s standards and matches the structure of the other new assets.Wable-iOS/Resource/Color.xcassets/Team/hle10.colorset/Contents.json (1)
1-20: Approved: hle10 color set JSON is complete and valid.
The JSON defines the color with the proper components (red:0xFB, green:0xEE, blue:0xE6) and metadata, conforming to the asset catalog specifications and design system guidelines.Wable-iOS/Resource/Color.xcassets/Team/t150.colorset/Contents.json (1)
1-20: New Team Color Set (t150) is well-structured.
The JSON file correctly defines the color using the sRGB color space with the proper hexadecimal components and includes the mandatory metadata. This aligns with the design system requirements outlined in the PR.Wable-iOS/Resource/Color.xcassets/Secondary/blue50.colorset/Contents.json (1)
1-20: Secondary Color Set (blue50) is defined correctly.
The file follows the standard format for color assets with all necessary keys (colors array, color-space, components, idiom, and info) and uses the proper hexadecimal values. The structure is consistent with other similar color files in the project.Wable-iOS/Resource/Color.xcassets/Team/ns10.colorset/Contents.json (1)
1-20: Team Color Set (ns10) is complete and compliant.
The JSON properly encapsulates the color components and metadata. The choice of identical hexadecimal values for each channel (0xE3) is correctly represented, and the universal idiom is appropriately applied.Wable-iOS/Resource/Color.xcassets/Team/dk50.colorset/Contents.json (1)
1-20: Team Color Set (dk50) JSON file is accurate.
All the required fields are present and correctly formatted. The RGBA components (with 0x4F for red, 0x55 for green, and 0x51 for blue) and the metadata conform with the project’s design system expectations.Wable-iOS/Resource/Color.xcassets/Team/t110.colorset/Contents.json (1)
1-20: Team Color Set (t110) is implemented correctly.
The file accurately defines the color with the specified RGBA components and includes the correct "info" metadata. It meets the design system criteria and integrates smoothly with the other newly added color assets.Wable-iOS/Resource/Color.xcassets/Team/gen10.colorset/Contents.json (1)
1-21: Valid JSON structure and adherence to the design system.
The JSON file correctly defines a color set using the expected keys (“colors”, “color-space”, “components”, “idiom”, and “info”). The hex values (red: "0xF4", green: "0xF1", blue: "0xE8") and the alpha value ("1.000") are formatted consistently with the other assets. Please double-check that these specific color values align with the latest design specifications.Wable-iOS/Resource/Color.xcassets/Team/hle50.colorset/Contents.json (1)
1-21: New color asset “hle50.colorset” is correctly defined.
The file follows the established JSON structure and metadata conventions (using sRGB, defining “components” with appropriate hex values, and marking the idiom as "universal"). Please confirm with the design team that the chosen values (red: "0xF4", green: "0x73", blue: "0x20", alpha: "1.000") are final.Wable-iOS/Resource/Color.xcassets/Team/drx50.colorset/Contents.json (1)
1-21: “drx50.colorset” asset is formatted as expected.
The JSON file properly encapsulates the new color definition including the sRGB components (red: "0x10", green: "0x04", blue: "0xA4", alpha: "1.000") and the required metadata. Ensure that these values meet the intended design guidelines and that similar files in the project remain consistent with this formatting approach.
👻 PULL REQUEST
📄 작업 내용
🔗 연결된 이슈
Summary by CodeRabbit