[Feat] 소식 탭 큐레이션 UI 구현하기 #290

JinUng41 · 2025-10-16T15:49:54Z

👻 PULL REQUEST

📄 작업 내용

소식 탭의 큐레이션 UI를 구현하였습니다.
URL이동은 네이버로 임시 구현하였습니다.
API 명세서가 나오는대로 서버를 통한 작업을 이어나갈 예정입니다.

구현 내용	iPhone 13 mini
페이징
새로고침
URL이동
엠티뷰

🔗 연결된 이슈

Resolved: [Feat] 큐레이션 UI 구현하기 #289

- 하단 로딩 인디케이터 기능 구현 필요

…o feat/#289-overview-curation

- 추후 작업을 위한 투두 주석 추가

Copilot

Pull Request Overview

This PR implements the UI for the curation tab in the news section, featuring paginated content loading with pull-to-refresh functionality. The implementation includes a view controller, cell, view model, and data model for displaying curated content items.

Key changes:

Created complete MVVM architecture for curation feature with pagination support
Implemented custom collection view cell with press animation and URL navigation
Added mock data generation for testing until API specification is available

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`CurationViewController.swift`	Main view controller implementing collection view with pull-to-refresh and pagination
`CurationCell.swift`	Custom cell displaying thumbnail, title, source with tap interaction
`CurationViewModel.swift`	View model handling data fetching, pagination logic with mock data
`CurationItem.swift`	Data model with mock samples for curation content
`project.pbxproj`	Xcode project file updates for new source files
`btn_curation.imageset/Contents.json`	Asset catalog entry for curation button icon

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-16T15:50:40Z

Wable-iOS/Presentation/Overview/Curation/ViewModel/CurationViewModel.swift

+final class CurationViewModel {
+
+    private var lastItemID: UUID?
+    private var hasMore: Bool = false


The properties lastItemID and hasMore are accessed from multiple threads (main queue and processingQueue) without synchronization, creating potential race conditions. Consider using @MainActor for the class or protecting these properties with proper synchronization.

Copilot · 2025-10-16T15:50:41Z

Wable-iOS/Presentation/Overview/Curation/View/CurationViewController.swift

+                title: item.title,
+                source: item.source
+            ) {
+                UIApplication.shared.open(URL(string: "https://www.naver.com")!)


Force unwrapping the URL will crash if the string is invalid. Use guard let or if let to safely unwrap the URL before opening it.

Suggested change

UIApplication.shared.open(URL(string: "https://www.naver.com")!)

if let url = URL(string: "https://www.naver.com") {

UIApplication.shared.open(url)

}

Copilot · 2025-10-16T15:50:41Z

Wable-iOS/Presentation/Overview/Curation/View/Cell/CurationCell.swift

+        $0.isAccessibilityElement = false
+    }
+
+    private let descriptionView = UIView(backgroundColor: UIColor("F7F7F7")).then {


The color value 'F7F7F7' is a magic value. Consider defining it as a named color in the asset catalog or as a constant to improve maintainability.

youz2me

고생하셨습니다~!

youz2me · 2025-10-17T14:11:16Z

Wable-iOS/Presentation/Overview/Curation/View/Cell/CurationCell.swift

+
+import UIKit
+
+


음? 여기 개행이 두번 들어갔어요

youz2me · 2025-10-17T14:13:33Z

Wable-iOS/Presentation/Overview/Curation/View/Cell/CurationCell.swift

+        $0.contentMode = .scaleAspectFill
+        $0.clipsToBounds = true
+        $0.backgroundColor = .gray200
+        $0.isAccessibilityElement = false


오... 이건 어떤 프로퍼티인가요?

접근성(예: VoiceOver)등을 위한 프로퍼티인데, 코파일럿 자동완성시치가 했던것을 지우지 않았습니다.

지우도록 하겠습니다.

youz2me · 2025-10-17T14:14:30Z

Wable-iOS/Presentation/Overview/Curation/View/Cell/CurationCell.swift

+    private let authorLabel = UILabel().then {
+        $0.attributedText = "와블 큐레이터".pretendardString(with: .body3)
+        $0.textColor = .wableBlack
+    }
+
+    private let timeLabel = UILabel().then {
+        $0.attributedText = "· 2시간 전".pretendardString(with: .caption4)
+        $0.textColor = .gray500
+    }


이렇게 해두면 통신을 통해 데이터가 들어가기 전에 유저에게 보여질 위험이 있어서 저는 공백으로 해두는 편이긴 합니다

그거 아주 좋은 생각 같습니다.
반영하겠습니다.

- 빈 줄 삭제 - 빈 문자열로 대체 - 관련 없는 코드 제거

[Feat] 소식 탭 큐레이션 UI 구현하기

JinUng41 added 8 commits October 16, 2025 17:37

[Add] #289 - 버튼 이미지 추가

7524d2a

[Feat] #289 - 큐레이션 UI 구현

1fc222c

[Refactor] #289 - MVVM 구조로 변경

a3140c5

- 하단 로딩 인디케이터 기능 구현 필요

[Feat] #289 - 더 불러올 때 하단 로딩 인디케이터 동작 추가

0249357

[Style] #289 - 오토레이아웃 수정

369f84f

[Chore] #289 - 제목이 길어졌을 때를 대비한 텍스트 수정

b0039ab

Merge branch 'develop' of https://github.com/Team-Wable/WABLE-iOS int…

b8b6bc0

…o feat/#289-overview-curation

[Chore] #289 - 투두 주석 남기기

1e5aba3

- 추후 작업을 위한 투두 주석 추가

JinUng41 requested review from Copilot and youz2me October 16, 2025 15:49

JinUng41 self-assigned this Oct 16, 2025

JinUng41 added this to Wable-iOS Oct 16, 2025

JinUng41 added ✨ feat 기능 또는 객체 구현 🍻 진웅 술 한잔 가온나~ labels Oct 16, 2025

Copilot AI reviewed Oct 16, 2025

View reviewed changes

youz2me approved these changes Oct 17, 2025

View reviewed changes

github-project-automation bot moved this to In Review in Wable-iOS Oct 17, 2025

[Chore] #289 - 리뷰 반영

ed3979f

- 빈 줄 삭제 - 빈 문자열로 대체 - 관련 없는 코드 제거

JinUng41 merged commit af80cf8 into develop Oct 17, 2025

github-project-automation bot moved this from In Review to Done in Wable-iOS Oct 17, 2025

JinUng41 deleted the feat/#289-overview-curation branch October 17, 2025 18:04

youz2me pushed a commit that referenced this pull request Oct 26, 2025

[Merge] pull request #290 from feat/#289-overview-curation

9768880

[Feat] 소식 탭 큐레이션 UI 구현하기

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feat] 소식 탭 큐레이션 UI 구현하기 #290

[Feat] 소식 탭 큐레이션 UI 구현하기 #290

Uh oh!

JinUng41 commented Oct 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

Copilot AI Oct 16, 2025

Uh oh!

youz2me left a comment

Uh oh!

youz2me Oct 17, 2025

Uh oh!

youz2me Oct 17, 2025

Uh oh!

JinUng41 Oct 17, 2025

Uh oh!

youz2me Oct 17, 2025

Uh oh!

JinUng41 Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-                UIApplication.shared.open(URL(string: "https://www.naver.com")!)
+                if let url = URL(string: "https://www.naver.com") {
+                    UIApplication.shared.open(url)
+                }


		import UIKit

[Feat] 소식 탭 큐레이션 UI 구현하기 #290

[Feat] 소식 탭 큐레이션 UI 구현하기 #290

Uh oh!

Conversation

JinUng41 commented Oct 16, 2025

👻 PULL REQUEST

📄 작업 내용

🔗 연결된 이슈

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

youz2me left a comment

Choose a reason for hiding this comment

Uh oh!

youz2me Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

youz2me Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

JinUng41 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

youz2me Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

JinUng41 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants