[WTH-140] Deploy Job 분리

[hyxklee]

📌 Summary

어떤 작업인지 한 줄 요약해 주세요.

deploy-dev, deploy-prod에서 build, deploy job을 분리했습니다

📝 Changes

변경사항을 what, why, how로 구분해 작성해 주세요.

What

• deploy job 분리

Why

• 배포만 실패한 경우 빌드르르 스킵하고 재배포할 수 있도록

How

📸 Screenshots / Logs

필요시 스크린샷 or 로그를 첨부해주세요.

💡 Reviewer 참고사항

리뷰에 참고할 내용을 작성해주세요.

✅ Checklist

• PR 제목 설정 완료 (WTH-123 인증 필터 설정)
• 테스트 구현 완료
• 리뷰어 등록 완료
• 자체 코드 리뷰 완료

Summary by CodeRabbit

릴리스 노트

• Chores
  • CI/CD 워크플로우를 재구성하여 빌드와 배포 프로세스를 분리했습니다.
  • 빌드 단계에 포괄적인 검증 및 이미지 생성 단계를 추가했습니다.
  • 배포는 빌드 성공 후에만 실행되도록 변경했습니다.

[coderabbitai]

📝 Walkthrough

워크스루

배포-개발 및 배포-프로덕션 워크플로우를 재구성하여 기존 배포 작업을 빌드로 이름 변경하고, 빌드 작업의 성공에 의존하는 새로운 배포 작업을 분리했습니다. 빌드와 배포 단계가 순차적으로 실행됩니다.

변경사항

cohort / 파일(s)	요약
워크플로우 구조 재구성 .github/workflows/deploy-dev.yml, .github/workflows/deploy-prod.yml	기존 deploy 작업을 build로 이름 변경하고, needs: build 및 if: needs.build.result == 'success' 조건을 포함한 새로운 deploy 작업 추가. CI 단계(JDK 설정, Gradle 빌드, Docker 멀티-아키텍처 빌드)는 build 작업에 통합되고, 배포 단계(SCP 업로드, SSH 배포)는 새로운 deploy 작업으로 이동.

예상 코드 리뷰 노력

🎯 2 (Simple) | ⏱️ ~8 분

시

🐰 빌드와 배포 나뉘어 깔끔하게,
작업들이 차곡차곡 쌓여가고,
한 발 한 발 성공의 길로,
워크플로우는 더욱 똑똑해졌네!
버니 개발팀, 이제 더욱 빠르겠군요! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Merge Conflict Detection	⚠️ Warning	⚠️ Unable to check for merge conflicts: Invalid branch name format

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	PR 제목 'WTH-140 Deploy Job 분리'는 pull request의 주요 변경사항인 배포 작업의 분리를 명확하게 요약하고 있습니다.
Description check	✅ Passed	PR 설명은 대부분의 필수 섹션을 포함하고 있으나, 'How' 섹션이 비어있어 변경 방법에 대한 구체적인 설명이 부족합니다.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/WTH-140-weeth-server-CICD-개선

⚔️ Resolve merge conflicts (beta)

• Auto-commit resolved conflicts to branch refactor/WTH-140-weeth-server-CICD-개선
• Create stacked PR with resolved conflicts
• Post resolved changes as copyable diffs in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

.github/workflows/deploy-dev.yml (1)

69-69: 불필요한 조건문입니다.

deploy-prod.yml과 동일하게, needs: build가 지정된 경우 기본적으로 의존 job 성공 시에만 실행됩니다. 이 조건문은 중복입니다.

♻️ 제안: 불필요한 조건문 제거

   deploy:
     needs: build
     runs-on: ubuntu-latest
-    if: needs.build.result == 'success'

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/deploy-dev.yml at line 69, Remove the redundant
conditional "if: needs.build.result == 'success'" from the deploy job in the
workflow; since the job already declares needs: build, the job will only run on
a successful build by default, so delete that if line (search for the literal
if: needs.build.result == 'success' within the deploy job) to match
deploy-prod.yml behavior.

.github/workflows/deploy-prod.yml (1)

61-61: 불필요한 조건문입니다.

needs: build가 지정된 경우, GitHub Actions의 기본 동작은 의존 job이 성공했을 때만 실행됩니다. if: needs.build.result == 'success' 조건은 중복됩니다.

♻️ 제안: 불필요한 조건문 제거

   deploy:
     needs: build
     runs-on: ubuntu-latest
-    if: needs.build.result == 'success'

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/deploy-prod.yml at line 61, The `if: needs.build.result ==
'success'` condition is redundant because the job already depends on `needs:
build`; remove the `if: needs.build.result == 'success'` line from the job
definition so the job relies on the default dependency behavior; keep the
existing `needs: build` entry and ensure no other conditional logic is
referencing `needs.build.result` elsewhere.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/deploy-prod.yml:
- Around line 64-65: The Checkout step using "uses: actions/checkout@v6" lacks a
ref, so the workflow may checkout the default branch instead of the release tag;
update that step to include a ref that targets the release tag (e.g., use
github.event.release.tag_name or github.ref for tag events) so the exact release
commit is checked out during the prod deployment.

---

Nitpick comments:
In @.github/workflows/deploy-dev.yml:
- Line 69: Remove the redundant conditional "if: needs.build.result ==
'success'" from the deploy job in the workflow; since the job already declares
needs: build, the job will only run on a successful build by default, so delete
that if line (search for the literal if: needs.build.result == 'success' within
the deploy job) to match deploy-prod.yml behavior.

In @.github/workflows/deploy-prod.yml:
- Line 61: The `if: needs.build.result == 'success'` condition is redundant
because the job already depends on `needs: build`; remove the `if:
needs.build.result == 'success'` line from the job definition so the job relies
on the default dependency behavior; keep the existing `needs: build` entry and
ensure no other conditional logic is referencing `needs.build.result` elsewhere.

[coderabbitai]

⚠️ Potential issue | 🟠 Major

Checkout 시 ref를 명시해야 합니다.

deploy-dev.yml에서는 ref: ${{ github.event.workflow_run.head_sha }}를 사용하여 정확한 커밋을 checkout하지만, prod workflow에서는 ref가 없습니다. release 이벤트에서는 기본적으로 default branch를 checkout하므로, 릴리스 태그에 해당하는 코드가 아닐 수 있습니다.

🐛 제안: release tag 기준으로 checkout

       - name: Checkout
         uses: actions/checkout@v6
+        with:
+          ref: ${{ github.event.release.tag_name }}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	- name: Checkout
	uses: actions/checkout@v6
	- name: Checkout
	uses: actions/checkout@v6
	with:
	ref: ${{ github.event.release.tag_name }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/deploy-prod.yml around lines 64 - 65, The Checkout step
using "uses: actions/checkout@v6" lacks a ref, so the workflow may checkout the
default branch instead of the release tag; update that step to include a ref
that targets the release tag (e.g., use github.event.release.tag_name or
github.ref for tag events) so the exact release commit is checked out during the
prod deployment.