Skip to content

Fix async logging #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NathanEdg merged 4 commits into from
Feb 11, 2026
Merged

Fix async logging #16

NathanEdg merged 4 commits into from
Feb 11, 2026

Conversation

@NathanEdg
Copy link
Member

@NathanEdg NathanEdg commented Feb 7, 2026

Fixed async logging by adding typed parameters to SpikeSystem

@NathanEdg NathanEdg requested a review from a team February 7, 2026 16:01
@NathanEdg NathanEdg linked an issue Feb 7, 2026 that may be closed by this pull request
Fix async logger library #9
Closed
@NathanEdg NathanEdg requested a review from bjmcternan February 7, 2026 16:01
@NathanEdg NathanEdg mentioned this pull request Feb 7, 2026
Open
bjmcternan
bjmcternan reviewed Feb 7, 2026
View reviewed changes
bjmcternan
bjmcternan reviewed Feb 7, 2026
View reviewed changes
bjmcternan
bjmcternan reviewed Feb 7, 2026
View reviewed changes
bjmcternan
bjmcternan requested changes Feb 7, 2026
View reviewed changes
Copy link
Contributor

@bjmcternan bjmcternan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to cleanup

@NathanEdg NathanEdg requested a review from bjmcternan February 8, 2026 23:03
bjmcternan
bjmcternan requested changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@bjmcternan bjmcternan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last fix

bjmcternan
bjmcternan approved these changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@bjmcternan bjmcternan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

afranchuk
afranchuk previously requested changes Feb 9, 2026
View reviewed changes
Copy link

@afranchuk afranchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this looks fine (aside from some extraneous System.out.println). I'm requesting changes mainly so the PR name/description mentions more than just the async logging, and mentions that #8 will be closed.

@bjmcternan bjmcternan requested a review from a team February 9, 2026 18:12
@NathanEdg NathanEdg requested a review from afranchuk February 9, 2026 19:13
@NathanEdg
Copy link
Member Author

NathanEdg commented Feb 11, 2026

@afranchuk @PillageDev are you able to review this to allow for merge

@NathanEdg NathanEdg removed the request for review from afranchuk February 11, 2026 17:57
@NathanEdg NathanEdg merged commit d1f5608 into develop Feb 11, 2026
2 checks passed
@NathanEdg NathanEdg deleted the 9-fix-async-logger-library branch February 11, 2026 17:59
@afranchuk afranchuk mentioned this pull request Feb 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjmcternan bjmcternan bjmcternan approved these changes

@PillageDev PillageDev PillageDev approved these changes

@maxim-kudryashov maxim-kudryashov maxim-kudryashov approved these changes

@afranchuk afranchuk afranchuk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix async logger library

6 participants

@NathanEdg @afranchuk @bjmcternan @PillageDev @maxim-kudryashov @ImSpxrsh