Skip to content

Search bars for Match and Pit Scouting#23

Merged
cherriae merged 2 commits intomainfrom
search-bars
Apr 5, 2025
Merged

Search bars for Match and Pit Scouting#23
cherriae merged 2 commits intomainfrom
search-bars

Conversation

@cherriae
Copy link
Copy Markdown
Member

@cherriae cherriae commented Apr 5, 2025

Summary

Title

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. subsystem).
  • This PR is not a code change (e.g. README, typehinting, examples, refactoring, ...)

@cherriae cherriae requested a review from Copilot April 5, 2025 14:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • app/templates/scouting/matches.html: Language not supported
  • app/templates/scouting/pit-scouting.html: Language not supported

Comment thread app/static/js/pit-scouting/list.js Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@cherriae cherriae requested a review from Copilot April 5, 2025 14:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • app/templates/scouting/matches.html: Language not supported
  • app/templates/scouting/pit-scouting.html: Language not supported
Comments suppressed due to low confidence (1)

app/static/js/pit-scouting/list.js:151

  • The code assumes that the search input element always exists. Consider adding a null check for 'searchInput' before attaching the event listener to prevent potential runtime errors.
const searchInput = document.getElementById('teamSearchInput');

@cherriae cherriae merged commit 397ca6d into main Apr 5, 2025
13 checks passed
@cherriae cherriae deleted the search-bars branch April 5, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants