feat: searchable user selector for report per-user page#62
Merged
Conversation
… searchable Replaces the non-searchable Select.Root in the report/user page with a shared UserCombobox component (Chakra Combobox.Root + useFilter) that mirrors the searchable pattern already used on the logs page. Cleans up the inline combobox in LogsTable.tsx to use the same component. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Memoize users array in LogsTable to prevent useEffect firing set() on every render, which was clearing the user's in-progress search text - Restore minWidth="44" on UserReportContent's UserCombobox to match the old Select.Root's minimum width constraint - Add emptyText prop to UserCombobox so callers can pass translated strings; wire LogsPage with next-intl and add zh-TW translation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserComboboxcomponent (src/components/UserCombobox.tsx) wrapping Chakra UI'sCombobox.RootwithuseFilter+useListCollectionfor search-as-you-type filteringSelect.Rootin/report/user(UserReportContent.tsx) with<UserCombobox>— users can now search by nameCombobox.Rootin the logs page filter (LogsTable.tsx) with the same shared component — behaviour unchangedTest plan
/report/user— user selector should be a searchable combobox; typing a partial name filters the list/logs— user filter combobox works identically to beforenpx tsc --noEmitpasses with no errors🤖 Generated with Claude Code