Skip to content

Use shutil.move instead of os.rename#3

Merged
ramen merged 1 commit intomainfrom
windows-rename-fix
Feb 5, 2024
Merged

Use shutil.move instead of os.rename#3
ramen merged 1 commit intomainfrom
windows-rename-fix

Conversation

@ramen
Copy link
Copy Markdown

@ramen ramen commented Jan 31, 2024

Path.rename calls os.rename, which does not support moving files to other directories on Windows. Use shutil.move instead.

@ramen ramen requested review from mikeylove and roelsan January 31, 2024 17:55
Copy link
Copy Markdown

@mikeylove mikeylove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@ramen ramen merged commit 55ce3d0 into main Feb 5, 2024
@ramen ramen deleted the windows-rename-fix branch February 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants